[Innovation Week] feat: stored events schema for action and view #222
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @guilhermevrs and the rest of your teammates on |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| /** | ||
| * Whether the View corresponding to this event is considered active | ||
| */ | ||
| is_active?: boolean; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Prop name (is_active) doesn't match rule (is|has) (...read more)
Enforces a consistent naming pattern for boolean props.
The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.
| /** | ||
| * Whether the View had a low average refresh rate | ||
| */ | ||
| is_slow_rendered?: boolean; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Prop name (is_slow_rendered) doesn't match rule (is|has) (...read more)
Enforces a consistent naming pattern for boolean props.
The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.
| /** | ||
| * Whether this session has been sampled for replay | ||
| */ | ||
| sampled_for_replay?: boolean; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Prop name (sampled_for_replay) doesn't match rule (is|has) (...read more)
Enforces a consistent naming pattern for boolean props.
The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.
| /** | ||
| * Whether session replay recording configured to start manually | ||
| */ | ||
| start_session_replay_recording_manually?: boolean; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Prop name (start_session_replay_recording_manually) doesn't match rule (is|has) (...read more)
Enforces a consistent naming pattern for boolean props.
The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.
| var __exportStar = (this && this.__exportStar) || function(m, exports) { | ||
| for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p); | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected var, use let or const instead. (...read more)
Block scoped lexical declarations like let and const are preferred over var. Block scope is common in many other programming languages and helps programmers avoid mistakes.
| if (k2 === undefined) k2 = k; | ||
| o[k2] = m[k]; | ||
| })); | ||
| var __exportStar = (this && this.__exportStar) || function(m, exports) { |
There was a problem hiding this comment.
⚪ Code Quality Violation
| var __exportStar = (this && this.__exportStar) || function(m, exports) { | |
| var _Exportstar = (this && this.__exportStar) || function(m, exports) { |
Use 'camelCase' and not 'snake_case' (...read more)
Ensure that variables and properties names use camelCase and not snake_case or PascalCase.
| "use strict"; | ||
| var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { | ||
| if (k2 === undefined) k2 = k; | ||
| var desc = Object.getOwnPropertyDescriptor(m, k); |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected var, use let or const instead. (...read more)
Block scoped lexical declarations like let and const are preferred over var. Block scope is common in many other programming languages and helps programmers avoid mistakes.
| if (k2 === undefined) k2 = k; | ||
| var desc = Object.getOwnPropertyDescriptor(m, k); | ||
| if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) { | ||
| desc = { enumerable: true, get: function() { return m[k]; } }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
| @@ -0,0 +1,17 @@ | |||
| "use strict"; | |||
| var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { | |||
There was a problem hiding this comment.
⚪ Code Quality Violation
| var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { | |
| var _Createbinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) { |
Use 'camelCase' and not 'snake_case' (...read more)
Ensure that variables and properties names use camelCase and not snake_case or PascalCase.
| }) : (function(o, m, k, k2) { | ||
| if (k2 === undefined) k2 = k; | ||
| o[k2] = m[k]; | ||
| })); |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
| /** | ||
| * Whether this session is currently active. Set to false to manually stop a session | ||
| */ | ||
| is_active?: boolean; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Prop name (is_active) doesn't match rule (is|has) (...read more)
Enforces a consistent naming pattern for boolean props.
The pattern is: "^(is|has)[A-Z]([A-Za-z0-9]?)+" to enforce is and has prefixes.
[Innovation Week] feat: stored events schema for action and view
feat: adds common events props