Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-6852: floating points support #237

Merged
merged 1 commit into from
Dec 12, 2024
Merged

RUM-6852: floating points support #237

merged 1 commit into from
Dec 12, 2024

Conversation

satween
Copy link
Contributor

@satween satween commented Dec 11, 2024

Improving previous PR a bit - effective_sample_rate should support floating point values

0xnm
0xnm approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title should be changed to be more descriptive: it should reflect the property changed

@satween satween marked this pull request as ready for review December 12, 2024 10:39
@satween satween requested review from a team as code owners December 12, 2024 10:39
@satween satween merged commit 81c3d74 into master Dec 12, 2024
12 checks passed
@satween satween deleted the tvaleev/rum-6852/floating_point_values_support branch December 12, 2024 12:00
@simaoseica-dd simaoseica-dd mentioned this pull request Dec 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

@0xnm 0xnm 0xnm approved these changes

@hemeryar hemeryar hemeryar approved these changes

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@satween @mariusc83 @hemeryar @0xnm @simaoseica-dd