Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-6581] Add other feature flag collection event #244

Merged
merged 4 commits into from
Jan 14, 2025
+8 −8
Merged

[RUM-6581] Add other feature flag collection event #244

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45f8abc
Add other feature flag collection
RomanGaignault Jan 13, 2025
d8b3d63
remove default values
RomanGaignault Jan 13, 2025
459932b
change init parameter name
RomanGaignault Jan 13, 2025
9e808e2
update description
RomanGaignault Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/cjs/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,9 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
*/
is_main_process?: boolean;
/**
* The list of events that include feature flags collection
* The list of events that include feature flags collection. The tracking is enabled by default on views and errors.
*/
collect_feature_flags_on?: ('view' | 'error' | 'vital')[];
track_feature_flags_for_events?: ('vital' | 'resource' | 'action' | 'long_task')[];
/**
* Whether the anonymous users are tracked
*/
Expand Down
4 changes: 2 additions & 2 deletions lib/esm/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,9 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
*/
is_main_process?: boolean;
/**
* The list of events that include feature flags collection
* The list of events that include feature flags collection. The tracking is enabled by default on views and errors.
*/
collect_feature_flags_on?: ('view' | 'error' | 'vital')[];
track_feature_flags_for_events?: ('vital' | 'resource' | 'action' | 'long_task')[];
/**
* Whether the anonymous users are tracked
*/
Expand Down
2 changes: 1 addition & 1 deletion samples/telemetry-events/configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"option_foo": "bar"
}
],
"collect_feature_flags_on": ["error", "view", "vital"]
"track_feature_flags_for_events": ["long_task", "resource", "vital"]
}
}
}
6 changes: 3 additions & 3 deletions schemas/telemetry/configuration-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,13 +414,13 @@
"type": "boolean",
"description": "Whether the SDK is initialised on the application's main or a secondary process"
},
"collect_feature_flags_on": {
"track_feature_flags_for_events": {
"type": "array",
"items": {
"type": "string",
"enum": ["view", "error", "vital"]
"enum": ["vital", "resource", "action", "long_task"]
},
"description": "The list of events that include feature flags collection"
"description": "The list of events that include feature flags collection. The tracking is enabled by default on views and errors."
RomanGaignault marked this conversation as resolved.
Show resolved Hide resolved
},
"track_anonymous_user": {
"type": "boolean",
Expand Down
Loading