Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack bot for npm publish failure #557

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Nov 21, 2024

Motivation

NPM publish failed, but Slack bot step was skipped.

What does this PR do?

Fix the Slack bot triggered by npm publish failure, similar to https://github.com/DataDog/serverless-self-monitoring/pull/286

Testing Guidelines

Steps

  1. Add this to publish.yml
on:
  release:
    types: [created]
+ push:
  1. Push

Result

Message was sent:
image

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@lym953 lym953 requested a review from a team as a code owner November 21, 2024 20:28
@lym953 lym953 force-pushed the yiming.luo/github-action-npm-3 branch from ba0899e to bfb9a97 Compare December 19, 2024 17:14
@lym953 lym953 merged commit cdd0e97 into main Dec 19, 2024
8 checks passed
@lym953 lym953 deleted the yiming.luo/github-action-npm-3 branch December 19, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants