Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Tracing payload request/response support #562

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

enricop89
Copy link

What does this PR do?

This PR adds the support for the AWS Cloud Payload tagging: https://docs.datadoghq.com/tracing/guide/aws_payload_tagging/#overview. The env variables added are:

  1. captureCloudRequestPayload
  2. captureCloudResponsePayload

Motivation

Customers able to use these new options + feature parity

Testing Guidelines

I tested using a local repo and trying different inputs

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • [x ] This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • [x ] This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • [x ] This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog

@enricop89 enricop89 requested review from a team as code owners December 19, 2024 14:35
Copy link
Contributor

@lym953 lym953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving to Cloud Tracing team for another review

src/env.ts Outdated Show resolved Hide resolved
src/env.ts Outdated Show resolved Hide resolved
@jhgilbert jhgilbert self-assigned this Dec 19, 2024
Copy link

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion, along with the typos flagged by another reviewer. Thank you!

README.md Outdated Show resolved Hide resolved
@lym953 lym953 requested a review from a team December 19, 2024 18:48
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants