v2/pkg/stratus/runner: Allow concurrent NewRunner() #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests in github.com/datadog/threatest failed when I ran them on my machine, because they call NewRunner() from multiple goroutines at the same time. If you have never run them before, they will attempt to create the directories at the same time, causing all but one to panic(). This adds a test to reproduce this, and fixes it by ignoring the "already exists" errors.
|
Hmm... looks like I may need to figure out how to fake terraform for this test; one moment |
|
Closing as discussed in PM, feel free to reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The tests in github.com/datadog/threatest failed when I ran them on my machine, because they call NewRunner() from multiple goroutines at the same time. If you have never run them before, they will attempt to create the directories at the same time, causing all but one to panic(). This adds a test to reproduce this, and fixes it by ignoring the "already exists" errors.
Motivation
I am attempting to do some internal upgrades to code that transitively depends on this and discovered the failing tests.