Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dinky-common] Fix deserialization exceptions caused by incorrect get methods in enum fields. #4077

Merged
merged 8 commits into from
Dec 23, 2024

Conversation

Jam804
Copy link
Contributor

@Jam804 Jam804 commented Dec 21, 2024

[Bug] [dinky-common] Fix deserialization exceptions caused by incorrect get methods in enum fields.

image

image

@aiwenmo aiwenmo added the Bug Something isn't working label Dec 23, 2024
@aiwenmo aiwenmo added this to the 1.2.1 milestone Dec 23, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 1f73bc9 into DataLinkDC:dev Dec 23, 2024
16 checks passed
@aiwenmo
Copy link
Contributor

aiwenmo commented Dec 23, 2024

Hi. Thanks for your fix.
Could you pull a request into 1.2 branch?

@Jam804
Copy link
Contributor Author

Jam804 commented Dec 23, 2024

Hi. Thanks for your fix. Could you pull a request into 1.2 branch?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants