Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-122: _untag_object #134

Merged
merged 41 commits into from
Sep 18, 2024
Merged

Conversation

doulikecookiedough
Copy link
Contributor

@doulikecookiedough doulikecookiedough commented Sep 17, 2024

Summary of Changes:

  • Refactored tag_object to call a new method, _store_hashstore_refs_files, re-raising specific exceptions.
  • Added and used new synchronization locks to ensure thread safety in tag_object
  • Implemented _store_hashstore_refs_files to handle unexpected exceptions by calling _untag_object while swallowing expected ones.
  • _untag_object now reverts the tagging process as much as possible, with new supporting methods for clarity.
  • Extracted synchronization code for improved readability.
  • Renamed exceptions for clarity, introduced new custom exceptions, and enhanced logging for debugging.
  • Cleaned up test modules and organized code for better structure (this will be reviewed more closely in the release prep PR).
  • Added new pytests and fixed bugs discovered during the process

Side Note:

  • I used the word "functions" and "methods" in my commit messages a little absentmindedly, these commits should have been "methods" (ex. a method belongs to a class while a function stands alone).

…or 'store_object' to reject duplicate calls to store objects for a pid already in progress and update pytest
…lude additional debug info if there is an issue
…n immediately, rename that exception from 'PidAlreadyExistsError' to 'PidRefsAlreadyExistsError' and update pytests
…r 'tag_object', update pytests and add TODO item
…ocked_cids' and rename existing sync method with '_' to be private
…d new sync methods '_synchronize_referenced_locked_pids' & '_release_reference_locked_pids'
…rence_locked_cids' to '_synchronize_object_locked_cids' for accuracy
…' and catching specific exceptions to improve clarity for expected possible exceptions
…exceptions, and to catch all other exceptions to begin untagging process (todo item)
… '_check_reference_locked_pids' and update 'untag_object'
…und' for clarity, update pytests and add skeleton code to 'untag_object'
…k_cid_lock', update 'untag_object' and add new todo pytest items
…e code, add pytests and resolve todo items in 'references' test module
…hstore' test module and delete redundant 'references' test module
…odule and delete redundant 'stream' test module
…ll exceptions when attempting to rename a pid refs file) from '_untag_object' and add pytest
@doulikecookiedough doulikecookiedough merged commit 93cce0f into develop Sep 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant