-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-122: _untag_object
#134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or 'store_object' to reject duplicate calls to store objects for a pid already in progress and update pytest
…lude additional debug info if there is an issue
…n immediately, rename that exception from 'PidAlreadyExistsError' to 'PidRefsAlreadyExistsError' and update pytests
…r 'tag_object', update pytests and add TODO item
…ocked_cids' and rename existing sync method with '_' to be private
…d new sync methods '_synchronize_referenced_locked_pids' & '_release_reference_locked_pids'
…rence_locked_cids' to '_synchronize_object_locked_cids' for accuracy
…' and catching specific exceptions to improve clarity for expected possible exceptions
…exceptions, and to catch all other exceptions to begin untagging process (todo item)
… '_check_reference_locked_pids' and update 'untag_object'
…und' for clarity, update pytests and add skeleton code to 'untag_object'
…k_cid_lock', update 'untag_object' and add new todo pytest items
…untag_object' function
…e code, add pytests and resolve todo items in 'references' test module
…' test module into 'interface' test module
…hstore' test module and delete redundant 'references' test module
…odule and delete redundant 'stream' test module
…acy and revise docstrings for accuracy
…ll exceptions when attempting to rename a pid refs file) from '_untag_object' and add pytest
…sts, and update '_untag_object'
…levant code and add new pytests
…d missing logging statement and fix bug in '_validate_and_check_cid_lock'
…ing', fix bug in '_untag_object' when catching exceptions and add new pytest
…e' test modules into its respective test folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
tag_object
to call a new method,_store_hashstore_refs_files
, re-raising specific exceptions.tag_object
store_hashstore_refs_files
to handle unexpected exceptions by calling_untag_object
while swallowing expected ones._untag_object
now reverts the tagging process as much as possible, with new supporting methods for clarity.Side Note: