Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-85: Code Review Optimizations #86

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Feature-85: Code Review Optimizations #86

merged 13 commits into from
Jan 25, 2024

Commits on Jan 23, 2024

  1. Tidy up logging statements in '_verify_object_information()'

    @doulikecookiedough
    doulikecookiedough committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    a921a7d View commit details
    Browse the repository at this point in the history

  2. Update 'ObjectMetadata' class attribute 'id' to 'cid' and revise all … 

    …affected code, tests and documentation
    @doulikecookiedough
    doulikecookiedough committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d0cf912 View commit details
    Browse the repository at this point in the history

  3. Add new pytest for 'delete_metadata' to confirm exception is not thro… 

    …wn when called to delete metadata that does not exist
    @doulikecookiedough
    doulikecookiedough committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c1d5403 View commit details
    Browse the repository at this point in the history

  4. Revise logging statement for accuracy in 'store_data_only()'

    @doulikecookiedough
    doulikecookiedough committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    ff8c03f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Add new method '_is_pid_in_cid_refs_file' and refactor '_verify_hashs… 

    …tore_references', 'find_object' and 'tag_object'
    @doulikecookiedough
    doulikecookiedough committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    e7b746c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Refactor 'verify_object' to return boolean values and update docstrin… 

    …gs & pytests
    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8f6f879 View commit details
    Browse the repository at this point in the history

  2. Refactor 'delete_object' to handle exceptions raised from calling 'fi… 

    …nd_object'
    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4830d0d View commit details
    Browse the repository at this point in the history

  3. Revise 'find_object' to also check that cid retrieved exists before r… 

    …eturning the cid found, and update 'delete_object'
    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f7cffb8 View commit details
    Browse the repository at this point in the history

  4. Refactor '.replace' calls to use '.strip' instead where relevant

    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e534465 View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2025fc9 View commit details
    Browse the repository at this point in the history

  6. Add underscore to all non-Public API methods to reduce confusion and … 

    …update pytests
    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    63ed8d4 View commit details
    Browse the repository at this point in the history

  7. Update inaccurate docstring in 'HashStoreClient'

    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    f040cda View commit details
    Browse the repository at this point in the history

  8. Refactor '_load_properties' to be static and update pytests and affec… 

    …ted code
    @doulikecookiedough
    doulikecookiedough committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    031d468 View commit details
    Browse the repository at this point in the history