DH-4724/adding find_by method to instructionRepo

dataherald/api/fastapi.py

@@ -332,14 +332,10 @@ def get_instructions(
         self, db_connection_id: str, page: int = 1, limit: int = 10
     ) -> List[Instruction]:
         instruction_repository = InstructionRepository(self.storage)
-        instructions = instruction_repository.find_all()
-        filtered_instructions = []
-        for instruction in instructions:
-            if instruction.db_connection_id == db_connection_id:
-                filtered_instructions.append(instruction)
+        instructions = instruction_repository.find_by({"db_connection_id": db_connection_id})
         start_idx = (page - 1) * limit
         end_idx = start_idx + limit
-        return filtered_instructions[start_idx:end_idx]
+        return instructions[start_idx:end_idx]
 
     @override
     def delete_instruction(self, db_connection_id: str, instruction_id: str) -> dict:

dataherald/repositories/instructions.py

@@ -35,6 +35,15 @@ def find_by_id(self, id: str) -> Instruction | None:
             return None
         return Instruction(**row)
 
+    def find_by(self, query: dict) -> list[Instruction]:
+        rows = self.storage.find(DB_COLLECTION, query)
+        result = []
+        for row in rows:
+            obj = Instruction(**row)
+            obj.id = str(row["_id"])
+            result.append(obj)
+        return result
+
     def find_all(self) -> list[Instruction]:
         rows = self.storage.find_all(DB_COLLECTION)
         return [Instruction(id=str(row["_id"]), **row) for row in rows]