Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DH-4732 Datetime data types should be parsed as a string in query_results #192

Merged
merged 1 commit into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions dataherald/sql_generator/create_sql_query_status.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from datetime import date
from datetime import date, datetime
from decimal import Decimal

from sqlalchemy import text
Expand Down Expand Up @@ -30,9 +30,10 @@ def create_sql_query_status(
for row in result:
modified_row = {}
for key, value in zip(row.keys(), row, strict=True):
if (
type(value) is date
): # Check if the value is an instance of datetime.date
if type(value) in [
date,
datetime,
]: # Check if the value is an instance of datetime.date
modified_row[key] = str(value)
elif (
type(value) is Decimal
Expand Down