Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DID resolution #31

Merged
merged 17 commits into from
Dec 24, 2024
Merged

DID resolution #31

merged 17 commits into from
Dec 24, 2024

Conversation

DavidBuchanan314
Copy link
Owner

WIP. Will close #29

Requires a new db table, requiring a simple "migration" process for existing millipds instances. Need to think about that - might stack up a few other db changes (AUTOINCREMENTing some id columns)

@DavidBuchanan314
Copy link
Owner Author

We need to prevent SSRF. See aio-libs/aiohttp#10224

Timeouts are already handled by the aiohttp client (although they're quite long, we might want to think about customising them).

@DavidBuchanan314 DavidBuchanan314 marked this pull request as ready for review December 24, 2024 21:50
@DavidBuchanan314 DavidBuchanan314 merged commit 648d065 into main Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DID resolution
1 participant