Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type any in favor of generic class #284

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Remove type any in favor of generic class #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94c6917
Update base.ts
adwulfran Oct 9, 2024
edd2c79
Update cat.ts
adwulfran Oct 9, 2024
c47e53d
Update user.ts
adwulfran Oct 9, 2024
c528a50
chore: remove double space
DavideViolante Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/controllers/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { Request, Response } from 'express';
import { Model } from 'mongoose';

abstract class BaseCtrl {
abstract class BaseCtrl<T> {

// eslint-disable-next-line @typescript-eslint/no-explicit-any
abstract model: any;
abstract model:Model<T>

// Get all
getAll = async (req: Request, res: Response) => {
Expand Down
4 changes: 2 additions & 2 deletions server/controllers/cat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Cat from '../models/cat';
import Cat, { ICat } from '../models/cat';
import BaseCtrl from './base';

class CatCtrl extends BaseCtrl {
class CatCtrl extends BaseCtrl<ICat> {
model = Cat;
}

Expand Down
4 changes: 2 additions & 2 deletions server/controllers/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { sign, Secret } from 'jsonwebtoken';
import { Request, Response } from 'express';

import User from '../models/user';
import User, { IUser } from '../models/user';
import BaseCtrl from './base';

const secret: Secret = process.env.SECRET_TOKEN as string;

class UserCtrl extends BaseCtrl {
class UserCtrl extends BaseCtrl<IUser> {
model = User;

login = async (req: Request, res: Response) => {
Expand Down