Fix safe performance offences

Also ignore Minitest/NonExecutableTestMethod for the moment because of
#927

.rubocop.yml

@@ -62,6 +62,10 @@ Metrics/PerceivedComplexity:
 Minitest/MultipleAssertions:
   Enabled: false
 
+# FIXME: DavyJonesLocker/client_side_validations#927
+Minitest/NonExecutableTestMethod:
+  Enabled: false
+
 Rails/ApplicationRecord:
   Exclude:
     - 'test/**/*'

lib/client_side_validations/extender.rb

@@ -7,7 +7,7 @@ module Extender
     def extend(klass, validators)
       validators.each do |validator|
         require "client_side_validations/#{klass.underscore}/#{validator.downcase}"
-        const_get(klass)::Validations.const_get("#{validator}Validator").send :include, ClientSideValidations.const_get(klass).const_get(validator)
+        const_get(klass)::Validations.const_get(:"#{validator}Validator").send :include, ClientSideValidations.const_get(klass).const_get(validator)
       end
     end
   end

test/action_view/models/category.rb

@@ -12,7 +12,7 @@ class Category
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

test/action_view/models/comment.rb

@@ -12,7 +12,7 @@ class Comment
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

test/action_view/models/format_thing.rb

@@ -35,7 +35,7 @@ class FormatThing
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

test/action_view/models/post.rb

@@ -17,7 +17,7 @@ class Post
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end
 

test/action_view/models/tag.rb

@@ -10,7 +10,7 @@ class Tag
 
   def initialize(params = {})
     params.each do |attr, value|
-      public_send("#{attr}=", value)
+      public_send(:"#{attr}=", value)
     end
   end