Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy images #37

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix deploy images #37

merged 1 commit into from
Apr 25, 2024

Conversation

Kuniwak
Copy link
Member

@Kuniwak Kuniwak commented Apr 25, 2024

Built images missing from docker push.

NOTE: Previously, we used to separate the processes into "build-image" and "push-image." We did this because, when building and pushing multiple images, the sequence:

  1. build A
  2. build B
  3. build C
  4. push A
  5. push B
  6. push C

ensures that if the build of B or C fails, A is not pushed. However, with the sequence:

  1. build A
  2. push A
  3. build B
  4. push B
  5. build C
  6. push C

A ends up being pushed regardless.


Contribution License Agreement

@Kuniwak Kuniwak self-assigned this Apr 25, 2024
@Kuniwak Kuniwak merged commit 8289616 into master Apr 25, 2024
3 checks passed
@Kuniwak Kuniwak deleted the fix-deploy-images branch April 25, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant