-
Notifications
You must be signed in to change notification settings - Fork 518
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added gha trigger to release and put the unless condition under the s…
…ame 'when' condition as the release (#1744)
- Loading branch information
1 parent
3bb1161
commit ae087fa
Showing
2 changed files
with
65 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: 'Ci Release Trigger' | ||
|
||
on: | ||
release: | ||
types: [ published ] | ||
|
||
workflow_dispatch: | ||
|
||
|
||
jobs: | ||
trigger-circleci: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Trigger Circle CI | ||
id: trigger_circle_ci | ||
uses: CircleCI-Public/trigger-circleci-pipeline-action@v1.1.0 | ||
env: | ||
CCI_TOKEN: ${{ secrets.CIRCLE_CI_TOKEN }} |
ae087fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure (and it's not documented) what the change meant to fix. I'm changing it back, and @Yonatan-Kaplounov you can explain what you did here and we can re-enter your changes.
ae087fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ae087fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation that is missing is why you did the changes, and what issue they meant to fix. Nothing is mentioned in the PR (#1744 ) as well.
I highly doubt that a release flow that runs for ~2 years will stop behaving the same one morning, so when you come back, you can gather proofs for your claims and we can take a second look and re-enter your changes :)