Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved logic of update of _best_ckpt_metrics before we build state dict #2007

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Moved logic of update of _best_ckpt_metrics before we build state dict #2007

merged 1 commit into from
Jun 2, 2024

Conversation

BloodAxe
Copy link
Contributor

This PR fixes a bug when _best_ckpt_metrics key was not updated in state dictionary of saved checkpoint

shaydeci
shaydeci approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit f3b8947 into master Jun 2, 2024
6 checks passed
@BloodAxe BloodAxe deleted the feature/SG-000-fix-best_ckpt_metric_not_saved branch June 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaydeci shaydeci shaydeci approved these changes

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @shaydeci