Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 livecoding / utils #52

Merged
merged 4 commits into from
Oct 31, 2017
Merged

📝 livecoding / utils #52

merged 4 commits into from
Oct 31, 2017

Conversation

fabienjuif
Copy link
Member

@@ -143,5 +143,26 @@ Welcome to our source speech repository about [mobx-state-tree](https://github.c

### Utils

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the onPatch topic sentence to introduce this topic

README.md Outdated
@@ -143,5 +143,26 @@ Welcome to our source speech repository about [mobx-state-tree](https://github.c

### Utils
#### [#41](https://github.com/Dedetat/pimp-my-powerpuff/pull/41/files) - onPatch
> Some debuging tools ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • move to Utils description (and add a verb)
  • introduce quickly this topic (may be use the first point ?)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging

README.md Outdated
@@ -143,5 +143,26 @@ Welcome to our source speech repository about [mobx-state-tree](https://github.c

### Utils
#### [#41](https://github.com/Dedetat/pimp-my-powerpuff/pull/41/files) - onPatch
> Some debuging tools ?
1. We are sick of `console.log` everywhere, maybe **mobx-state-tree** can help us ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this sentence a introduction to the topic

README.md Outdated
> Some debuging tools ?
1. We are sick of `console.log` everywhere, maybe **mobx-state-tree** can help us ?
2. Yes it can! 😎
3. We import `onPatch` from **mobx-state-tree**, it allows us to listen to all patches applied to our store, we use it to simply print these patches

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] mobx-state-tree: it allows us [...]. Here we use it [...]

README.md Outdated
2. Yes it can! 😎
3. We import `onPatch` from **mobx-state-tree**, it allows us to listen to all patches applied to our store, we use it to simply print these patches
4. We remove all the `console.log` and add the `onPatch` listener to our `store` instance, right after we created it
5. Now as we run the demo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge 5. and 6. as a single sentence

README.md Outdated
- path
- action type
- value
8. This is our prefered tool to debug our store 💚!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our favorite tool to debug the store

README.md Outdated

#### [#42](https://github.com/Dedetat/pimp-my-powerpuff/pull/42/files) - onSnapshot
> What if we want to print the complete store snapshot after each mutation ? 🤔
1. Ok this one, the last one, is an easy one!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm questionning: this one what ? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step (#42)

README.md Outdated

#### [#42](https://github.com/Dedetat/pimp-my-powerpuff/pull/42/files) - onSnapshot
> What if we want to print the complete store snapshot after each mutation ? 🤔
1. Ok this one, the last one, is an easy one!
2. Replace all the `onPatch` to `onSnapshot` and tada 🎉 🎉!!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace all [...] by [..]

Copy link

@delphinemillet delphinemillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't satisfied with the descriptions 😞

README.md Outdated
@@ -142,6 +142,26 @@ Welcome to our source speech repository about [mobx-state-tree](https://github.c
#### [#40](https://github.com/Dedetat/pimp-my-powerpuff/pull/40/files) - Reference an identifier

### Utils
> Maybe there is some debugging tools we could use?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are sick of console.log everywhere, maybe mobx-state-tree can help us ? Yes it can! 😎
Let's see some debugging tools it provides

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(replace by this sentence)

README.md Outdated
#### [#41](https://github.com/Dedetat/pimp-my-powerpuff/pull/41/files) - onPatch
> We are sick of `console.log` everywhere, maybe **mobx-state-tree** can help us ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we track each changes done on our store ?

README.md Outdated
#### [#41](https://github.com/Dedetat/pimp-my-powerpuff/pull/41/files) - onPatch
> We are sick of `console.log` everywhere, maybe **mobx-state-tree** can help us ?
1. Yes it can! 😎

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

README.md Outdated
#### [#41](https://github.com/Dedetat/pimp-my-powerpuff/pull/41/files) - onPatch
> How can we track each changes done on our store

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? is missing (not a big deal !)

Copy link

@delphinemillet delphinemillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, not required to merge

@fabienjuif fabienjuif merged commit e19bf83 into master Oct 31, 2017
@fabienjuif fabienjuif deleted the utils branch October 31, 2017 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants