Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: [snyk] modified .snyk policy file to exclude vendor/github.com/Azure/go-auto… #169

Closed
wants to merge 3 commits into from
Closed

security: [snyk] modified .snyk policy file to exclude vendor/github.com/Azure/go-auto… #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
356a261
modified .snyk policy file to exclude vendor/github.com/Azure/go-auto…
pacificcode Aug 26, 2024
ae2516c
added changie entry for this PR
pacificcode Aug 26, 2024
c762c2b
Merge branch 'main' into bh.snyk.ignore
pacificcode Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/security-20240826-071628.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: security
body: Modified .snyk policy file to exclude vendor/github.com/Azure/go-autorest/Gopkg.lock
time: 2024-08-26T07:16:28.399741-07:00
1 change: 1 addition & 0 deletions .snyk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@ ignore: {}
patch: {}
exclude:
global:
- vendor/github.com/Azure/go-autorest/Gopkg.lock
- vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we merge this let's figure out why it's not working, since you should only have to specify a folder, not a subfolder. This list should be minimal so lets look at docs and then if that doesn't answer, reach out to security team on why it's not working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheldonhull security team is aware of this issue. Alexa Kessler did her homework on this issue and verified with with Snyk representatives. She would be the source of authority for any further/specific details.
This PR's primary function is to test if including this single file in the .snyk policy file "exclude" directive will eliminate the snyk web UI from reporting these "High" level vulnerabilities. FYI, the snyk cli does not report the vulnerabilities being addressed by this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pacificcode I'm discussing with Alexa for some context before merging since there's some research I did on this prior that might have relevance. Once I confirm with her I'll either approve or update here with more context, so leave this open temporarily and I'll resolve it once I get some details to add. Didn't want you to think I'd forgotten :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheldonhull any update on this? it would be great to get it merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same update from 2 weeks ago. I did bump the internal conversation and will update once I have something more, or you can bump that thread as well. 🙇🏻

- .devcontainer/
Loading