Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new station: Lobster Station (Second PR, ignore the first one) #2094

Open
wants to merge 148 commits into
base: master
Choose a base branch
from

Conversation

PubliclyExecutedPig
Copy link

@PubliclyExecutedPig PubliclyExecutedPig commented Nov 2, 2024

Adds lobster station

About the PR

Lobster station, named because its shaped like a lobster, is a modern and expensive station, mainly focussed on research and development, income from passengers (like a resort), with a strong security to back it

Why / Balance

To add some variation to the map pool, especially on apoapsis, whilst being quite unique in its characteristics... kinda like a dv fland station (but hopefully better, also this is a second PR bc idk how to update my first one's files)

Technical details

Media

Lobster-0

Requirements

Breaking changes

Changelog

🆑

-add: Lobster Station, a medium pop station! (actual lobster is not guaranteed and is at the discretion of the chefs)

@ewokswagger
Copy link
Contributor

ewokswagger commented Nov 4, 2024

https://github.com/PubliclyExecutedPig/Delta-v/blob/430c1508e7f9c8541b98cd69d4ed1307ab739fe4/Content.IntegrationTests/Tests/PostMapInitTest.cs#L46-L64

You need to update the integration tests to include Lobster station. (edit: linked wrong code)

@github-actions github-actions bot added the Changes: C# Changes any cs files label Nov 5, 2024
@PubliclyExecutedPig
Copy link
Author

https://github.com/PubliclyExecutedPig/Delta-v/blob/430c1508e7f9c8541b98cd69d4ed1307ab739fe4/Content.IntegrationTests/Tests/PostMapInitTest.cs#L46-L64

You need to update the integration tests to include Lobster station. (edit: linked wrong code)

well i've fixed that and the test still fails :/

@deltanedas
Copy link
Member

you dont need to merge master every 5 seconds :trollface:

@PubliclyExecutedPig
Copy link
Author

you dont need to merge master every 5 seconds :trollface:

you cant stop me

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
@PubliclyExecutedPig
Copy link
Author

was vertex removed or something what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Map Changes: YML Changes any yml files S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants