Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New weapon - I.C.E.E. #2170

Merged
merged 23 commits into from
Dec 19, 2024
Merged

New weapon - I.C.E.E. #2170

merged 23 commits into from
Dec 19, 2024

Conversation

Stop-Signs
Copy link
Contributor

@Stop-Signs Stop-Signs commented Nov 11, 2024 •
edited
Loading

About the PR

Added a Cold Laser for epi to research. The cold laser, or I.C.E.E., deals 20 cold and reduces body temp. It will be a T3 in the arsenal tree.

Why / Balance

More Content YAYYYYYYY. Adds some cool (pun intended) counterplay to the "speed is key" combat meta

Technical details

TO DO

  • Make the projectile
  • Sprite the weapon (likely a recolor of the laser cannon
  • tech tree
  • lathe recipe
  • Weapon code itself
  • Possibly more that im forgetting :3

Media

Icon

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Credits

HUGE credit to OrksAreDaBest and deltanedas for helping me in C#
Changelog

🆑

  • add: I.C.E.E, a laser that deals cold, is now available for epi to research

@github-actions github-actions bot added the Changes: YML Changes any yml files label Nov 11, 2024
@Stop-Signs
Copy link
Contributor Author

Right, so the main issue im dealing with is the lack of a way to make a hitscan laser modify body temp. if anyone knows how to do that please let me know.

@ThataKat
Copy link
Contributor

I am totally talking off the top of my head here but have you looked into the ice wing watcher code? It's projectile isn't hitscan to my recollection, but it does exactly what you're talking about.

@Stop-Signs
Copy link
Contributor Author

I am totally talking off the top of my head here but have you looked into the ice wing watcher code? It's projectile isn't hitscan to my recollection, but it does exactly what you're talking about.

so that only works for projectiles, not hitscan. hitscan is shitcode and im currently working out a way to fix it

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

RSI Diff Bot; head commit 745a9b2 merging into f49142c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/cold_cannon.rsi

State Old New Status
0-inhand-left Added
0-inhand-right Added
25-inhand-left Added
25-inhand-right Added
50-inhand-left Added
50-inhand-right Added
75-inhand-left Added
75-inhand-right Added
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after 745a9b2

@Stop-Signs Stop-Signs marked this pull request as ready for review November 11, 2024 19:59
@Stop-Signs Stop-Signs requested review from IamVelcroboy and a team as code owners November 11, 2024 19:59
@Stop-Signs Stop-Signs changed the title New weapon - Cold Laser New weapon - I.C.E.E. Nov 11, 2024
@Stop-Signs
Copy link
Contributor Author

errors are from the sprites and i honestly dont know how to fix it

Radezolid
Radezolid approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 14, 2024
@CybersunOperative
Copy link

I like the concept of a cold laser. Gives security some added utility with a weapon that both slows and wounds targets. Seems fitting for a T3 damage wise.

Other voices in direction have voiced that they like it as well. Direction approves :3

@MilonPL MilonPL added S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Nov 26, 2024
@github-actions github-actions bot added the size/M 64-255 lines label Nov 26, 2024
@Stop-Signs Stop-Signs requested a review from MilonPL November 26, 2024 22:54
@github-actions github-actions bot added S: Needs Review and removed S: Awaiting Changes Do not merge due to requested changes labels Nov 26, 2024
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Stop-Signs
Merge branch 'master' into Cold-gun
7060d1b 
Signed-off-by: Stop-Signs <stopsign221@gmail.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Nov 30, 2024
@deltanedas deltanedas requested a review from a team as a code owner December 17, 2024 04:52
Lyndomen
Lyndomen previously approved these changes Dec 17, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 17, 2024
@Stop-Signs
Merge branch 'master' into Cold-gun
1128cd3 
Signed-off-by: Stop-Signs <stopsign221@gmail.com>
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Dec 17, 2024
deltanedas
deltanedas approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill fix nitpicks later

@deltanedas deltanedas merged commit 5da943a into DeltaV-Station:master Dec 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radezolid Radezolid Radezolid approved these changes

@deltanedas deltanedas deltanedas approved these changes

@Lyndomen Lyndomen Lyndomen left review comments

@IamVelcroboy IamVelcroboy Awaiting requested review from IamVelcroboy

@MilonPL MilonPL Awaiting requested review from MilonPL

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Stop-Signs @ThataKat @CybersunOperative @deltanedas @Lyndomen @MilonPL @Radezolid