cleanup and carrying refactor #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
size/XL
|
🔥🔥🔥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
good
Technical details
begone shitcode
removed the explicit escape from inventory thing since nothing uses it + escape from inventory should be able to just work
removed redundant checks and fleshed out CanCarry, it was checking if the user was alive when you cant start carrying when crit anyway
Media
felenid chucking amusement park...
Requirements
Breaking changes
moved everything from Content.Server.Carrying and Content.Shared.Carrying to Content.Shared.DeltaV.Carrying
CarrySlowdownComponent now only has 1 field, Modifier, that is applied for both sprint and walk speed
Changelog
🆑