Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ert Overhaul 4.0 #2552

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

Conversation

Tryded
Copy link
Contributor

@Tryded Tryded commented Dec 28, 2024

About the PR

Port Paradise Station ERT, Correctly this time. https://www.paradisestation.org/wiki/index.php/Emergency_Response_Team

Why / Balance

Makes it quicker to spawn ERT via the use of gamerules
Centers the ERT's arsenal around Energy Weaponry
Removes Pulse Rifles from main ERT's arsenal
Creates tiers of ERTs for different levels of threats.

Technical details

YAML gaming

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

To do:
Guns

  • IK-30 (For the Crew)
  • PDW-9 Rework
  • Advanced Energy Gun
  • Multi Lens Immolater Cannon
  • IK-60 Rework (ERT only)

Clothing

  • ERT hardsuit rebalance
  • Elite ERT hardsuits

Equipment

  • Combat RCD
  • Advanced Compact Defibrillator
    - [ ] Universal Pinpointers targeting the Team Leader separate PR
  • Holostretcher
  • Medkits of Medical Chemicals
  • Boxes of Mindshields
  • Boxes of C4s
  • [ ] Trash bags of holding

Spawning
- [ ] Gamerule for spawning ERT Pods Separate PR
- [ ] Map of the actual pods for the ERT Separate PR

  • ERT Ghostroles

Breaking changes

Changelog

🆑 Tryded

  • add: Added the advanced energy gun which self-recharges and has two settings: Disable and Kill. This is researchable by science.
  • tweak: There was a recent reorganization of the Emergency Response Teams by Nanotrasen.
    DELTAVADMIN:
  • add: Added new gamerules for spawning Emergency Response Teams. ERTs are now is different tiers which increases in this order: Amber, Red, Gamma.

@Tryded Tryded requested review from a team as code owners December 28, 2024 18:30
@Tryded Tryded marked this pull request as draft December 28, 2024 18:30
@github-actions github-actions bot added size/L 256-1023 lines S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi and removed S: Needs Review labels Dec 28, 2024
@Avalon-Proto
Copy link
Contributor

I am already liking the sound of this

@Lyndomen
Copy link
Contributor

This is dope, let me meetwith the team to find out what types of ERT would be good to have prebaked

@Radezolid
Copy link
Contributor

While you're at it, make the ERT Engineer hardsuit fireproof please.

@Unkn0wnGh0st333
Copy link
Contributor

If you need help mapping a ERT shuttle let me know

Copy link
Contributor

github-actions bot commented Dec 29, 2024

RSI Diff Bot; head commit c2f09e0 merging into 44413b0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/energygun_carbine.rsi

State Old New Status
base Removed
icon Removed
inhand-left Removed
inhand-right Removed
mag-unshaded-0 Removed
mag-unshaded-1 Removed
mag-unshaded-2 Removed
mag-unshaded-3 Removed
mag-unshaded-4 Removed

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertchaplain.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertengineer.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertjanitor.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertleader.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertmedical.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/Head/Hardsuits/ERThelmets/eliteertsecurity.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertchaplain.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertengineer.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertjanitor.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertleader.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertmedical.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/ERTSuits/eliteertsecurity.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Markers/jobs.rsi

State Old New Status
ertchaplaingamma Added
ertengineergamma Added
ertjanitorgamma Added
ertleadergamma Added
ertmedicalgamma Added
ertsecuritygamma Added

Resources/Textures/DeltaV/Objects/Medical/advancedcompactdefib.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added
screen Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Casings/laser_casing.rsi

State Old New Status
base-spent Added
base Added
tip Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Ammunition/Magazine/Energy/laser_mag.rsi

State Old New Status
base Added
mag-1 Added
mag-2 Added
mag-3 Added
mag-4 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/energygunadvanced.rsi

State Old New Status
base Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/immolator.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Battery/multi_lens_immolator.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added
wielded-inhand-left Added
wielded-inhand-right Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/lasercarbine.rsi

State Old New Status
base Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added
mag-1 Added
mag-2 Added
mag-3 Added
mag-4 Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Resources/Textures/DeltaV/Objects/Weapons/Guns/Rifles/lasercarbineert.rsi

State Old New Status
base Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added
mag-1 Added
mag-2 Added
mag-3 Added
mag-4 Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Resources/Textures/DeltaV/Structures/Furniture/rollerbeds.rsi

State Old New Status
rollerbed Added
rollerbed_buckled Added
rollerbed_folded Added

Edit: diff updated after c2f09e0

@github-actions github-actions bot added size/XL Over 1024 lines and removed size/L 256-1023 lines labels Dec 29, 2024
@Tryded Tryded marked this pull request as ready for review December 29, 2024 20:26
@Tryded Tryded requested a review from a team as a code owner December 29, 2024 20:26
@Tryded
Copy link
Contributor Author

Tryded commented Dec 30, 2024

I have no idea why is it failing

@Tryded Tryded marked this pull request as draft December 30, 2024 22:41
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 31, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR! S: Needs Review size/XL Over 1024 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants