Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved HOPs access configurator to the administrative assistant starting gear #2579

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Radezolid
Copy link
Contributor

About the PR

Removed the access configurator from the HOP's locker and gave one to the admin assistant starting gear.

Why / Balance

HOP being a service head of staff doesn't really use the access configurator, on the other hand, the administrative assistant would make more sense to be able to assist with changing accesses on doors or lockers should it be needed.

Technical details

2 YAML line change.
Touches upstream heads.yml.

Media

N/A

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None.

Changelog

No CL as the administrative assistant isn't public to the players yet.

@Radezolid Radezolid requested a review from a team as a code owner January 1, 2025 20:11
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files size/XS Under 16 lines and removed S: Needs Review labels Jan 1, 2025
@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 1, 2025

Do CEs get one? I forgor

@Radezolid
Copy link
Contributor Author

Radezolid commented Jan 1, 2025

Do CEs get one? I forgor

CE and HOP have one each in their lockers, with this it would be only CE and the admin assistant only if they spawn since they don't have a guaranteed locker.

@FieldCommand
Copy link
Contributor

To me, the hop having an access configurator seems to be a remnant from the time that they were considered second in command. Since HoP are now only service-related and head of said service department, it does not make sense for them to have one of two access configurations to me. I have never needed it as a hop, and more often than not when it has been needed, it has been the captain coming and taking it anyway. The CE having one does, as they are the ones most likely to need to reconfigure new airlocks. So moving it to the new administrative assistant to lend out to heads that need it does make sense, but that is also very dependent on mappers mapping the locker for the administrative assistant. But I would also like to see the captain getting one. And I don't even think the access configurator is a steal objective.

@Avalon-Proto
Copy link
Contributor

So moving it to the new administrative assistant to lend out to heads that need it does make sense, but that is also very dependent on mappers mapping the locker for the administrative assistant.

This is moving it to spawn in their inventory round start. The locker is an optional thing that is not needed w/ extra things

@HTMLSystem
Copy link
Contributor

As a HoP main I would like for the access config to stay with the HoP and the assistant could just get another one of their own? I've needed to use it a few times as HoP and it feels like we're taking away the very few things HoP CAN help with atp :(.

@deltanedas deltanedas merged commit d82b15a into DeltaV-Station:master Jan 2, 2025
19 checks passed
@Radezolid Radezolid deleted the admin-config branch January 2, 2025 14:39
@Radezolid
Copy link
Contributor Author

To me, the hop having an access configurator seems to be a remnant from the time that they were considered second in command.

It was.

very dependent on mappers mapping the locker for the administrative assistant.

Administrative assistants spawn with it on their pocket, not on locker exactly for that reason.

But I would also like to see the captain getting one.

No, the captain shouldn't have one, they should talk with the rest of the station to accomplish what they want as that's their role on station, to delegate.

And I don't even think the access configurator is a steal objective.

It isn't.

As a HoP main I would like for the access config to stay with the HoP and the assistant could just get another one of their own? I've needed to use it a few times as HoP and it feels like we're taking away the very few things HoP CAN help with atp :(.

HoP is head of service, it doesn't make sense for them to have that tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants