Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bionic voice mask implanter to Nukeop inventory #2611

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

mazziechai
Copy link
Contributor

About the PR

A new bionic voice mask implant is given to Nukies on spawn. This voice mask implant works the exact same as the bionic syrinx implant for Syndicate Harpies, except it is (for now) exclusive to Nukies.

Oh, and I didn't notice it when I committed, but my editor removed two trailing spaces in nukeops.yml. Sorry.

Why / Balance

This idea was brought up after discussion in the Discord about players using the chat-based nature of the the game to acquire personal details of Nukies (i.e. name).

Nukies have a way to hide their identity or presence in the round by default now. This could affect how rounds play out if Nukies decide to use someone else's name for a stealth op, but it could be quickly reported as suspicious if done incorrectly.

Technical details

BionicVoiceMaskImplant contains a SubdermalImplant component linked to ActionChangeVoiceMask. BionicSyrinxImplant inherits from BionicVoiceMaskImplant, rather than BaseSubdermalImplant.

Another implanter was added to accommodate. BionicSyrinxImplanter inherits from that.

Media

This could probably use a new icon, but I am not much of an artist:

The action icon for the bionic voice mask implant

Name getting changed to Bingus through this menu

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Extremely minor: BionicSyrinxImplant is no longer directly based on BaseSubdermalImplant but instead inherits from BionicVoiceMaskImplant.

Changelog

🆑

  • add: Nukies get a bionic voice mask implant on spawn that allows them to change their chat name and accent.

the Harpy specific BionicSyrinxImplanter inherits from this generic implant
@mazziechai mazziechai requested a review from a team as a code owner January 4, 2025 02:41
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files and removed size/S 16-63 lines labels Jan 4, 2025
@github-actions github-actions bot added the size/S 16-63 lines label Jan 4, 2025
@deltanedas deltanedas requested a review from a team January 4, 2025 03:01
@Stop-Signs
Copy link
Contributor

I love the idea of making this concept more accessible to nukies. however i think that its a direct buff to nukies, and also it completely invalidates the voice mask and TC cost that goes with it. maybe remove the voice mask from the uplink and make this one of those easy 1-2tc purchases

@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 4, 2025

24 hour direction review, thanks!

@mazziechai
Copy link
Contributor Author

I love the idea of making this concept more accessible to nukies. however i think that its a direct buff to nukies, and also it completely invalidates the voice mask and TC cost that goes with it. maybe remove the voice mask from the uplink and make this one of those easy 1-2tc purchases

I feel that it would actually encourage ops that aren't just run and gun kill everyone, which it seems to me that people think is an active problem.

I was encouraged to make this PR by Orks who is a contributor so that's why I did it in the first place, so sorry if it seems out of place.

@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 5, 2025

Hi! It does not seem out of place, we are still under debate on this though. Sorry!

Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! After extended debate, while this is overall a nukie buff, it encourages more forms of roleplay so direction approved. We will be monitoring this change.

@deltanedas deltanedas merged commit a189bbb into DeltaV-Station:master Jan 6, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants