Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default UserDemand boundary concentrations. #1843

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

evetion
Copy link
Member

@evetion evetion commented Sep 23, 2024

Fixes #1841

The fix is indeed to UserDemand, and @visr's hunch about the concentration not being set on the boundary turned out to be right.

Seems we're in business now 🎉:
Screenshot 2024-09-23 at 17 38 26

@evetion evetion requested a review from visr September 23, 2024 15:44
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I guess those colors are so close to 1 they just decided to call it 1 on both the low and high end!

@visr visr merged commit c9948a2 into main Sep 23, 2024
27 checks passed
@visr visr deleted the fix/delwaq-user-demand branch September 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass balance is off in HWS Delwaq model
2 participants