Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document parsing Delwaq results. #1845

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Document parsing Delwaq results. #1845

merged 11 commits into from
Oct 10, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Sep 24, 2024

And plot some, including:

  • Utility to add tracers to existing models
  • Adds default Initial (basin state) and UserDemand tracers
  • Make some fancy plots

fraction_example

fraction_spatial_example

@evetion
Copy link
Member Author

evetion commented Sep 24, 2024

Hmm, I forgot that we can't plot results, as we haven't run Delwaq in our docs.

@visr visr marked this pull request as draft October 1, 2024 11:00
@evetion evetion marked this pull request as ready for review October 8, 2024 14:49
@evetion
Copy link
Member Author

evetion commented Oct 8, 2024

Hmm, I forgot that we can't plot results, as we haven't run Delwaq in our docs.

After a discussion with @visr on this, we decided to upload the results of the Delwaq test to minio, and use that in our plots. It will lag behind somewhat, but that should be not matter too much for documentation purposes.

For that purposes I've added a upload_benchmark.py script (named to mirror the get_benchmark one) and improved both scripts to be more configurable (using personal keys) and argparse, and adjusted the TC configuration to match. The scripts should all use environment variables IMHO, but I'll leave that to another issue, as an implementation of DVC will supersede those improvements.

@evetion evetion requested a review from visr October 8, 2024 15:08
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

utils/get_benchmark.py Outdated Show resolved Hide resolved
utils/upload_benchmark.py Outdated Show resolved Hide resolved
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
@evetion evetion merged commit 5cff21d into main Oct 10, 2024
26 of 27 checks passed
@evetion evetion deleted the feat/delwaq-parse branch October 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants