Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for resetting cumulatives from BMI #1852

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Remove support for resetting cumulatives from BMI #1852

merged 3 commits into from
Oct 1, 2024

Conversation

visr
Copy link
Member

@visr visr commented Sep 30, 2024

The coupler is switching to an approach where they don't need to reset the cumulatives to 0. Since this complicated the Ribasim code, let's get rid of it.

The reason for the coupler to move away from resetting cumulatives is that this possibly broke with #1819.

The dedicated BMI arrays like vertical_flux_bmi and user_demand.realized_bmi are removed. The BMI.get_value_ptr now just points to the cumulative state, or if it is not a state (drainage, precipitation) to basin.cumulative_drainage or basin.cumulative_precipitation.

This is breaking because I also renamed these BMI variables to be more consistent with the current code, where we use the term cumulative internally.

user_demand.realized -> user_demand.inflow
basin.drainage_integrated -> basin.cumulative_drainage
basin.infiltration_integrated ->  basin.cumulative_infiltration

@visr visr added the breaking A change that breaks existing models label Sep 30, 2024
visr added a commit to Deltares/imod_coupler that referenced this pull request Sep 30, 2024
@visr visr requested a review from evetion September 30, 2024 16:38
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Realized seemed better than inflow. And it seems integrated vs cumulative is math vs non-math coders (I used similar wordings in my concentration PR), but we should come to an agreement for future internal documentation.

@visr visr merged commit f7eb895 into main Oct 1, 2024
27 checks passed
@visr visr deleted the no-bmi-reset branch October 1, 2024 09:08
rleander pushed a commit to Deltares/imod_coupler that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A change that breaks existing models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants