Don't write use_validation to TOML
#1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1862. This adds the default to a test model to ensure it doesn't end up that and hence make the model not runnable in CI.
visr
added a commit
that referenced
this pull request
Oct 3, 2024
Instead of latest. All PRs made since v0.31 came out seem to have pixi environment related issues. Checking if this will fix it. #1867 green with v0.30 #1868 red with v0.31 #1869 red with v0.31 This is the error, that somewhat randomly appears during `pixi run` ``` × /home/runner/work/Ribasim/Ribasim/.pixi/envs/dev/lib/gcc/x86_64-conda- │ linux-gnu/14.1.0/libhwasan.so: No such file or directory (os error 2) ```
visr
added a commit
that referenced
this pull request
Oct 3, 2024
Instead of latest. All PRs made since v0.31 came out seem to have pixi environment related issues. Checking if this will fix it. #1867 green with v0.30 #1868 red with v0.31 #1869 red with v0.31 This is the error, that somewhat randomly appears during `pixi run` ``` × /home/runner/work/Ribasim/Ribasim/.pixi/envs/dev/lib/gcc/x86_64-conda- │ linux-gnu/14.1.0/libhwasan.so: No such file or directory (os error 2) ``` The failing jobs share that they all run Julia code and are on Ubuntu, although there are also Julia and Ubuntu jobs that pass. `gcc_impl_linux-64` is a dependency of rust.
evetion
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1862.
This adds the default to a test model to ensure it doesn't end up that and hence make the model not runnable in CI.