Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It runs Dommel at similar speed to QNDF, and doesn't diverge over long timespans when iterating between drainage and infiltration on the bucket test model.
HWS model is 44s with Rodas5P vs 10s QNDF. Though QNDF is known to be wrong (#1851). With QNDF I get one large leak of -632063 and several 1e-8. With Rodas5P just one of 2.5e-6. So this addresses that as well.
On top of #1868.
TODO: fix tests, look into backwater model performance