Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease relative tolerance from 1e-5 to 1e-7 #1874

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Decrease relative tolerance from 1e-5 to 1e-7 #1874

merged 8 commits into from
Oct 8, 2024

Commits on Oct 7, 2024

  1. Decrease relative tolerance from 1e-5 to 1e-7

    With #1819 the state goes further away from 0 with time. That meanse we rely more on the relative tolerance than the aboslute tolerance.
    
    Reducing the default `reltol` by two orders of magnitude is enough to get only negligible leaky Terminals with occasional very brief leaks of 1e-8 m3/s. It is also enough to minimize the infiltration error to acceptable levels as can be seen in #1863 (comment).
    
    For HWS this slows down simulation from 9.1s to 12.3s, which isn't too bad for a two orders of magnitude reduction in relative tolerance.
    
    https://docs.sciml.ai/DiffEqDocs/stable/basics/faq/#What-does-tolerance-mean-and-how-much-error-should-I-expect
    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8a5d7db View commit details
    Browse the repository at this point in the history
  2. Set abstol to 1e-7 also

    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    74e4ed0 View commit details
    Browse the repository at this point in the history
  3. Fix tests

    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    92e10d6 View commit details
    Browse the repository at this point in the history
  4. Update regression and HWS tests

    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8ceffc7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d69ae0 View commit details
    Browse the repository at this point in the history
  6. oops

    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e22a24c View commit details
    Browse the repository at this point in the history
  7. relax integration test

    visr committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f8a74c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. TeamCity is slow

    visr committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    38a3136 View commit details
    Browse the repository at this point in the history