Test ribasim integration take 2 #335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch that has new added solvers
…nsidered as a cumulative quantity
…ch that has new added solvers
…nsidered as a cumulative quantity
…ero (state variable) by the coupler
|
My modifications have been incorporated into #334 which has been merged, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is like #334 but I changed or removed the last 5 commits there, to remove the timeouts and target Deltares/Ribasim#1874 instead.
You may still want to modify or rename
ribasim_user_realizedsince that now indeed is cumulative. On the Ribasim I renamed the variable touser_demand.cumulative_inflowfor clarity. I guessribasim_user_realized_saveis no longer needed?