Skip to content

Commit

Permalink
Mark pointer as FOLLY_NONNULL to satisfy nullability-completeness req…
Browse files Browse the repository at this point in the history
…uirement

Summary:
I do not have context to know whether this is nullable or non-nullable but this allows me to build the target without getting an error about nullability-completeness.

```
./xplat/folly/executors/CPUThreadPoolExecutor.h:182:25: error: pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified) [-Werror,-Wnullability-completeness]
  182 |   BlockingQueue<CPUTask>* getTaskQueue();
      |                         ^
./xplat/folly/executors/CPUThreadPoolExecutor.h:182:25: note: insert '_Nullable' if the pointer may be null
```

Reviewed By: yfeldblum

Differential Revision: D63988501

fbshipit-source-id: 98e0c2864c96022cbcb4355ffa0cec79893a7776
  • Loading branch information
Joe Susnick authored and facebook-github-bot committed Oct 9, 2024
1 parent 79c1a00 commit a1cf715
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion folly/executors/CPUThreadPoolExecutor.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ class CPUThreadPoolExecutor : public ThreadPoolExecutor,
static const size_t kDefaultMaxQueueSize;

protected:
BlockingQueue<CPUTask>* getTaskQueue();
BlockingQueue<CPUTask>* FOLLY_NONNULL getTaskQueue();
std::unique_ptr<ThreadIdWorkerProvider> threadIdCollector_{
std::make_unique<ThreadIdWorkerProvider>()};

Expand Down

0 comments on commit a1cf715

Please sign in to comment.