Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving several issues while installing LLTFI #72

Merged

Conversation

ranbir-sharma
Copy link
Contributor

@ranbir-sharma ranbir-sharma commented Jun 2, 2024

Problems

  1. For LLTFI, there is an extra folder which only contains the LLTFI repo, therefore removal is required for the extra LLTFI folder
  2. Replacement of path folder for LLTFI build is needed due to 1)
  3. Build for LLVM is needed in release mode to reduce memory space taken by the docker image
  4. After docker build, there were no env variables configured which causes extra steps for developer to do in order to run LLTFI
  5. Installing of json-c library needs sudo power in regular Linux desktop and does not need sudo power while running in docker, therefore need to have a new path for json-c where both of the cases above doesn't need sudo power
  6. wget command isn't installed after the docker build has been done

Solutions

  1. Extra folder for LLTFI is removed and now the new path is /home/LLTFI
  2. New path for LLTFI build is /home/LLTFI/build
  3. LLVM build is now done in release mode
  4. In dockerfile, the script ensures to set the env variables as well to have a smooth experience for developers to run LLTFI
  5. Pathway to install json-c library is now set to be ~/local since the path is in the user's home directory, the script would not require sudo power for both manual installation and dockerfile build
  6. Installation of wget is added within the Dockerfile

@ranbir-sharma ranbir-sharma marked this pull request as draft June 7, 2024 21:19
@ranbir-sharma ranbir-sharma marked this pull request as ready for review June 8, 2024 01:35
@abrahamchan
Copy link
Collaborator

These changes LGTM! Also, they have been tested.

@abrahamchan abrahamchan merged commit b23fed6 into DependableSystemsLab:master Jun 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants