Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle errors reading & writing the baseline file and report config / baseline errors more reliably #947

Merged
merged 10 commits into from
Dec 15, 2024
Merged

handle errors reading & writing the baseline file and report config / baseline errors more reliably #947

merged 10 commits into from
Dec 15, 2024

Conversation

DetachHead
Copy link
Owner

@DetachHead DetachHead commented Dec 13, 2024 •
edited
Loading

fixes #914

@DetachHead DetachHead changed the title Lsp error for baseline handle errors reading & writing the baseline file and report config / baseline errors more reliably Dec 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead
keep track of logged errors in StandardConsole to exit with a non-z…
4e7f17b 
…ero exit code when running in cli mode to reduce risk of new errors from upstream not being reported properly
@DetachHead
don't re-read the baseline file for each source file in the project
b2b7d54
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch from bde93e4 to b2b7d54 Compare December 13, 2024 12:22
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead
use Connection.sendNotification to show console errors in the langu…
8d8e76c 
…age server instead of `WindowInterface.showInformationMessage` because thatg causes tests to hang for some reason
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch 2 times, most recently from 6545ee4 to f73a71d Compare December 14, 2024 06:04
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch from f73a71d to 2b70c6b Compare December 14, 2024 07:23
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch from 2b70c6b to a472a2d Compare December 14, 2024 09:26
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch from df42fdf to a472a2d Compare December 14, 2024 13:15
@DetachHead
Copy link
Owner Author

looks like the missing errors in the primer comment are because i accidentally also fixed #63

@DetachHead
Copy link
Owner Author

wait actually no i didnt, it still runs but just doesn't output the result

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@DetachHead DetachHead force-pushed the lsp-error-for-baseline branch from 88e659c to 304f26d Compare December 15, 2024 00:33
@github-actions GitHub Actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

sympy (https://github.com/sympy/sympy)
-     Type of "P" is "(condition: Unknown, given_condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Any | BernoulliDistribution | Probability | Zero | One | Expr | Float | ComplexInfinity | Rational | NaN | NegativeOne | Integer | Half | Infinity | NegativeInfinity | _NotImplementedType | Self@Expr | tuple[Unknown, ...] | Sum | Piecewise | Basic | Equality | Lambda | Number | int | None)" (reportUnknownVariableType)
+     Type of "P" is "(condition: Unknown, given_condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Any | BernoulliDistribution | Probability | Zero | One | Expr | Float | ComplexInfinity | Rational | NaN | NegativeOne | Integer | Half | Infinity | NegativeInfinity | _NotImplementedType | Self@Expr | tuple[Unknown, ...] | Sum | Add | Piecewise | Basic | Equality | Lambda | Number | int | None)" (reportUnknownVariableType)
-     Type of "E" is "(expr: Unknown, condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Basic | Expectation | Expr | tuple[Unknown, ...] | Sum | Self@Expr | Any | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
+     Type of "E" is "(expr: Unknown, condition: Unknown | None = None, numsamples: Unknown | None = None, evaluate: bool = True, **kwargs: Unknown) -> (Unknown | Basic | Expectation | Expr | tuple[Unknown, ...] | Sum | Self@Expr | Any | Add | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
-     Type of "H" is "(expr: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (int | Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
+     Type of "H" is "(expr: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (int | Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Add | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
-     Type of "covariance" is "(X: Unknown, Y: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (CrossCovarianceMatrix | Covariance | Unknown | Basic | Expectation | Expr | tuple[Unknown, ...] | Sum | Self@Expr | Any | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
+     Type of "covariance" is "(X: Unknown, Y: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (CrossCovarianceMatrix | Covariance | Unknown | Basic | Expectation | Expr | tuple[Unknown, ...] | Sum | Self@Expr | Any | Add | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
-     Type of "entropy" is "(expr: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (int | Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
+     Type of "entropy" is "(expr: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (int | Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Add | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | None)" (reportUnknownVariableType)
-     Type of "factorial_moment" is "(X: Unknown, n: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
+     Type of "factorial_moment" is "(X: Unknown, n: Unknown, condition: Unknown | None = None, **kwargs: Unknown) -> (Expr | Basic | Expectation | tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Any | Add | Zero | NaN | Piecewise | Equality | Integral | ExpectationMatrix | Literal[0] | None)" (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:107:9 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Integral | Literal[0] | None", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:107:9 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Integral | Literal[0] | None", is partially unknown (reportUnknownParameterType)
-     Type of "compute_expectation" is "(expr: Unknown, rvs: Unknown | None = None, **kwargs: Unknown) -> (tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Literal[0] | None)" (reportUnknownMemberType)
+     Type of "compute_expectation" is "(expr: Unknown, rvs: Unknown | None = None, **kwargs: Unknown) -> (tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Literal[0] | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:113:20 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Literal[0] | None", is partially unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:113:20 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Literal[0] | None", is partially unknown (reportUnknownVariableType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:116:9 - warning: Return type, "Unknown | Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Sum | Expr | Any | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | Number | NegativeInfinity", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:116:9 - warning: Return type, "Unknown | Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Sum | Expr | Any | Add | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | Number", is partially unknown (reportUnknownParameterType)
-     Type of "probability" is "((condition: Unknown, **kwargs: Unknown) -> Unknown) | ((condition: Unknown) -> (Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Unknown | Sum | Expr | Any | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | Number | NegativeInfinity)) | ((condition: Unknown) -> (NaN | Unknown | Piecewise | Integer | Literal[0]))" (reportUnknownMemberType)
+     Type of "probability" is "((condition: Unknown, **kwargs: Unknown) -> Unknown) | ((condition: Unknown) -> (Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Unknown | Sum | Expr | Any | Add | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | Number)) | ((condition: Unknown) -> (NaN | Unknown | Piecewise | Integer | Literal[0]))" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:119:16 - warning: Return type, "Unknown | Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Sum | Expr | Any | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | Number | NegativeInfinity", is partially unknown (reportUnknownVariableType)
+   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:119:16 - warning: Return type, "Unknown | Zero | One | Probability | Self@Expr | tuple[Unknown, ...] | Sum | Expr | Any | Add | NaN | Piecewise | Basic | Equality | int | NegativeOne | Integer | Rational | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | Number", is partially unknown (reportUnknownVariableType)
-     Type of "expr" is "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Integral | None" (reportUnknownVariableType)
+     Type of "expr" is "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Integral | None" (reportUnknownVariableType)
-     Type of "_marginalise" is "(expr: Unknown, rv: Unknown, evaluate: Unknown) -> (tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Integral | None)" (reportUnknownMemberType)
+     Type of "_marginalise" is "(expr: Unknown, rv: Unknown, evaluate: Unknown) -> (tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Integral | None)" (reportUnknownMemberType)
-   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:197:9 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Zero | NaN | Piecewise | Basic | Equality | Integral | None", is partially unknown (reportUnknownParameterType)
+   /tmp/mypy_primer/projects/sympy/sympy/stats/compound_rv.py:197:9 - warning: Return type, "tuple[Unknown, ...] | Unknown | Sum | Self@Expr | Expr | Any | Add | Zero | NaN | Piecewise | Basic | Equality | Integral | None", is partially unknown (reportUnknownParameterType)

... (truncated 3987 lines) ...

arviz (https://github.com/arviz-devs/arviz): 3.43x slower (9.0s -> 30.7s in a single noisy sample)

@DetachHead DetachHead merged commit 1d61e75 into main Dec 15, 2024
20 checks passed
@DetachHead DetachHead deleted the lsp-error-for-baseline branch December 15, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

occasional crash when writing to baseline.json in language server
1 participant
@DetachHead