Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.12.0 #641

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Release v0.12.0 #641

merged 1 commit into from
Sep 25, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

Prepare the 0.12.0 release.

Still needs a vm test suite run!

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear added this to the 0.12.0 milestone Sep 22, 2023
@Hoverbear Hoverbear self-assigned this Sep 22, 2023
cole-h
cole-h approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Hoverbear
Copy link
Contributor Author

Seems #638 was incomplete, #196 also changed some tests. PR incoming.

@Hoverbear
Copy link
Contributor Author

#626 broke the vm-test uninstallCases.uninstall-shell-profile-clobbered because we no longer error if the user deleted a file (eg bash.rc) so that test needs to be deleted.

@Hoverbear Hoverbear mentioned this pull request Sep 22, 2023
Merged
6 tasks
@Hoverbear Hoverbear added the upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing label Sep 25, 2023
@Hoverbear
Copy link
Contributor Author

Noticed a bug with the configured settings display during my final testing, PR coming.

@Hoverbear Hoverbear mentioned this pull request Sep 25, 2023
Merged
6 tasks
@Hoverbear
Copy link
Contributor Author

Think that's all the kinks sorted out.

@Hoverbear Hoverbear merged commit aed05e9 into main Sep 25, 2023
@Hoverbear Hoverbear deleted the release-v0.12.0 branch September 25, 2023 20:36
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
upload to s3 The labeled PR is allowed to upload its artifacts to S3 for easy testing
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h