Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/deploy bug 147 #153

Closed
wants to merge 3 commits into from
Closed

Bug/deploy bug 147 #153

wants to merge 3 commits into from

Conversation

nakyeonko3
Copy link
Collaborator

@nakyeonko3 nakyeonko3 commented Sep 10, 2024

πŸš€ ν’€ λ¦¬ν€˜μŠ€νŠΈ μ œμ•ˆ

@coderabbitai: iπŸ€·β€β™€οΈgnore

πŸ“‹ μž‘μ—… λ‚΄μš©

μˆ˜μ •ν•œ λ‚΄μš©μ΄λ‚˜ μΆ”κ°€ν•œ κΈ°λŠ₯에 λŒ€ν•΄ μžμ„Ένžˆ μ„€λͺ…ν•΄ μ£Όμ„Έμš”.

πŸ”§ λ³€κ²½ 사항

  • πŸ“ƒ README.md
  • πŸ“¦ package.json
  • πŸ”₯ 파일 μ‚­μ œ
  • 🧹 κ·Έ μ™Έ ex) .gitignore λ“±

μ£Όμš” λ³€κ²½ 사항을 μš”μ•½ν•΄ μ£Όμ„Έμš”.

πŸ“Έ μŠ€ν¬λ¦°μƒ· (선택 사항)

μˆ˜μ •λœ ν™”λ©΄ λ˜λŠ” κΈ°λŠ₯을 μ‹œμ—°ν•  수 μžˆλŠ” μŠ€ν¬λ¦°μƒ·μ„ 첨뢀해 μ£Όμ„Έμš”.

πŸ“„ 기타

μΆ”κ°€μ μœΌλ‘œ μ „λ‹¬ν•˜κ³  싢은 λ‚΄μš©μ΄λ‚˜ νŠΉλ³„ν•œ μš”κ΅¬ 사항이 있으면 μž‘μ„±ν•΄ μ£Όμ„Έμš”.

Summary by CodeRabbit

### Release Notes

#### New Feature
- Added environment variables `VITE_ALGOLIA_APP_ID` and `VITE_ALGOLIA_SEARCH_API_KEY` for Algolia integration.
- Introduced `FIREBASE_CLI_PREVIEWS` environment variable for Firebase previews.
- Configured a new GitHub Actions workflow to push changes to another repository.

#### Chore
- Removed `VITE_FIREBASE_DATABASE_URL` from the TypeScript environment definitions.
- Added a new script (`build.sh`) to handle file copying and moving within the project directory.

- firebase-hosting-merge.yml νŒŒμΌμ— env λ³€μˆ˜λ“€μ΄ λͺ‡κ°€μ§€ λˆ„λ½λœ 것을
  μˆ˜μ •ν•¨.
- package.json에 express 쒅속성을 μ‚­μ œν•¨
Copy link

github-actions bot commented Sep 10, 2024

Image description CodeRabbit

Walkthrough

이번 λ³€κ²½ 사항은 Firebase와 Algolia 톡합을 μœ„ν•œ ν™˜κ²½ λ³€μˆ˜λ₯Ό μΆ”κ°€ν•˜κ³ , μƒˆλ‘œμš΄ GitHub μž‘μ—… 흐름을 μ„€μ •ν•˜λ©°, λΆˆν•„μš”ν•œ ν™˜κ²½ λ³€μˆ˜λ₯Ό μ œκ±°ν•˜λŠ” λ“±μ˜ μž‘μ—…μ„ ν¬ν•¨ν•©λ‹ˆλ‹€. λ˜ν•œ ν”„λ‘œμ νŠΈ νŒŒμΌμ„ 볡사 및 μ΄λ™ν•˜λŠ” μƒˆλ‘œμš΄ μŠ€ν¬λ¦½νŠΈκ°€ μΆ”κ°€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

Changes

파일 μš”μ•½
.github/workflows/firebase-hosting-merge.yml, .github/workflows/firebase-hosting-pull-request.yml VITE_ALGOLIA_APP_ID, VITE_ALGOLIA_SEARCH_API_KEY, FIREBASE_CLI_PREVIEWS ν™˜κ²½ λ³€μˆ˜κ°€ 좔가됨.
src/vite-env.d.ts VITE_FIREBASE_DATABASE_URL λ³€μˆ˜κ°€ μΈν„°νŽ˜μ΄μŠ€μ—μ„œ μ‚­μ œλ¨.
.github/workflows/push-to-another-repository.yml 또 λ‹€λ₯Έ μ €μž₯μ†Œλ‘œ ν‘Έμ‹œν•˜λŠ” μƒˆλ‘œμš΄ GitHub μž‘μ—… 흐름이 좔가됨.
build.sh ν”„λ‘œμ νŠΈ λ””λ ‰ν† λ¦¬μ˜ νŒŒμΌμ„ λ³΅μ‚¬ν•˜κ³  μ΄λ™ν•˜λŠ” μƒˆλ‘œμš΄ μŠ€ν¬λ¦½νŠΈκ°€ 좔가됨.

πŸ‡ μ½”λ“œκ°€ λ°”λ€Œμ–΄ μƒˆλ‘œμ›Œμ‘Œλ„€,
ν™˜κ²½ λ³€μˆ˜λ„ 좔가됐지, μ•Œλ§žκ²Œ.
GitHub 흐름도 μƒˆλ‘­κ²Œ ꡬ성,
ν”„λ‘œμ νŠΈλŠ” 이제 더 κ°•λ ₯ν•΄μ‘Œλ„€! πŸš€


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

github-actions bot commented Sep 10, 2024

Visit the preview URL for this PR (updated for commit 14bffca):

https://toy-project-2-team-4-pizza--preview-cuf8b9eo.web.app

(expires Wed, 11 Sep 2024 09:04:51 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: 70fe82c823fc0ae3a244966b629012f11f284e3b

- develop에 push 될 λ•Œ λ§ˆλ‹€ λ‹€λ₯Έ 리포둜 λ³΅μ‚¬ν•˜λŠ” workflow 생성
@nakyeonko3 nakyeonko3 changed the base branch from main to develop September 10, 2024 09:05
@nakyeonko3 nakyeonko3 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant