fix: #1772 code review 组件，代码展开按钮与评论相邻时，点击展开按钮会报错 #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatZPP
reviewed
Apr 24, 2024
| * @param _node 如果折叠行后一行左边获取不到行数，则寻找第一个左边有行数的行。 | ||
| * @returns 返回找到的后一个同级元素节点，如果没有找到则返回null。 | ||
| */ | ||
| export function findNextElement(_node: Element): Element { |
GreatZPP
reviewed
Apr 24, 2024
| * @returns 返回找到的后一个同级元素节点，如果没有找到则返回null。 | ||
| */ | ||
| export function findNextElement(_node: Element): Element { | ||
| if (_node.children[0]?.innerText) { |
GreatZPP
reviewed
Apr 24, 2024
| @@ -243,6 +270,7 @@ export function updateLineNumberInDatasetForDoubleColumn( | |||
| nextR = parseInt((nextLineNode.children[2] as HTMLElement).innerText) - 1; | |||
| const isExpandAll = nextLineNumber - prevLineNumber <= expandThreshold; | |||
| if (isExpandAll && updateExpandButton) { | |||
| trNode.style.display = 'none'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.