MenuItem: extend MenuBasePlainItem to support any string indexed prop…

…erties (#28610)
DevExpress · Dec 23, 2024 · 90626e0 · 90626e0
1 parent e96787e
commit 90626e0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/packages/devextreme/js/__internal/grids/grid_core/context_menu/m_context_menu.ts b/packages/devextreme/js/__internal/grids/grid_core/context_menu/m_context_menu.ts
@@ -109,7 +109,6 @@ export class ContextMenuView extends modules.View {
           }
         },
         onItemClick(params) {
-          // @ts-expect-error
           params.itemData?.onItemClick?.(params);
         },
 

diff --git a/packages/devextreme/js/__internal/ui/context_menu/m_menu_base.edit.strategy.ts b/packages/devextreme/js/__internal/ui/context_menu/m_menu_base.edit.strategy.ts
@@ -5,7 +5,6 @@ import PlainEditStrategy from '@ts/ui/collection/m_collection_widget.edit.strate
 
 class MenuBaseEditStrategy extends PlainEditStrategy {
   _getPlainItems(): Item {
-    // @ts-expect-error
     return map(this._collectionWidget.option('items'), function getMenuItems(item) {
       return item.items ? [item].concat(map(item.items, getMenuItems)) : item;
     });

diff --git a/packages/devextreme/js/ui/menu.d.ts b/packages/devextreme/js/ui/menu.d.ts
@@ -333,6 +333,8 @@ export interface MenuBasePlainItem extends CollectionWidgetItem {
    * @public
    */
   visible?: boolean;
+
+  [key: string]: any;
 }
 
 /**

diff --git a/packages/devextreme/ts/dx.all.d.ts b/packages/devextreme/ts/dx.all.d.ts
@@ -21267,6 +21267,8 @@ declare module DevExpress.ui {
        * [descr:dxMenuBaseItem.visible]
        */
       visible?: boolean;
+
+      [key: string]: any;
     }
     /**
      * [descr:_ui_menu_OptionChangedEvent]
-Original file line number
+Diff line change
@@ Expand Up / @@ -109,7 +109,6 @@ export class ContextMenuView extends modules.View { @@
               }
             },
             onItemClick(params) {
-              // @ts-expect-error
               params.itemData?.onItemClick?.(params);
             },
@@ Expand Down @@