Skip to content

Commit

Permalink
Widget: remove excess typing file
Browse files Browse the repository at this point in the history
  • Loading branch information
EugeniyKiyashko committed Dec 25, 2024
1 parent b26f849 commit ceb5585
Show file tree
Hide file tree
Showing 36 changed files with 166 additions and 270 deletions.
28 changes: 16 additions & 12 deletions packages/devextreme/js/__internal/core/widget/component.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Action from '@js/core/action';
import Class from '@js/core/class';
import type {
Component as PublicComponent,
ComponentOptions,
} from '@js/core/component';
import Config from '@js/core/config';
Expand Down Expand Up @@ -45,7 +46,7 @@ export class Component<
TProperties extends Properties<TComponent>,
// @ts-expect-error dxClass inheritance issue
// eslint-disable-next-line @typescript-eslint/ban-types
> extends (Class.inherit({}) as new() => {}) {
> extends (Class.inherit({}) as new() => {}) implements PublicComponent<TProperties> {
_deprecatedOptions!: Partial<TProperties>;

_options!: Options;
Expand Down Expand Up @@ -285,8 +286,8 @@ export class Component<
}
}

instance(): TComponent {
return this as unknown as TComponent;
instance(): this {
return this;
}

beginUpdate(): void {
Expand Down Expand Up @@ -372,7 +373,7 @@ export class Component<

_createActionByOption(
optionName: string,
config: Record<string, unknown>,
config?: Record<string, unknown>,
): (event?: Record<string, unknown>) => void {
// eslint-disable-next-line @typescript-eslint/init-declarations
let action;
Expand Down Expand Up @@ -406,15 +407,16 @@ export class Component<
actionFunc = this.option(optionName);
}

if (!action && !actionFunc && !config.beforeExecute
&& !config.afterExecute && !this._eventsStrategy.hasEvent(eventName)) {
if (!action && !actionFunc && !config?.beforeExecute
&& !config?.afterExecute && !this._eventsStrategy.hasEvent(eventName)) {
return;
}

if (!action) {
// @ts-expect-error
const { beforeExecute } = config;
// @ts-expect-error
config.beforeExecute = (...props): void => {
// @ts-expect-error
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/prefer-optional-chain, @typescript-eslint/no-unused-expressions
beforeExecute && beforeExecute.apply(this, props);
Expand Down Expand Up @@ -447,16 +449,17 @@ export class Component<
return onActionCreated(this, result, config) || result;
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
on(eventName: string, eventHandler): TComponent {
// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/ban-types
on(eventName: string | { [key: string]: Function }, eventHandler?): this {
this._eventsStrategy.on(eventName, eventHandler);
return this as unknown as TComponent;
return this;
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
off(eventName: string, eventHandler): TComponent {
off(eventName: string, eventHandler?): this {
this._eventsStrategy.off(eventName, eventHandler);
return this as unknown as TComponent;
return this;
}

hasActionSubscription(actionName: string): boolean {
Expand Down Expand Up @@ -490,6 +493,7 @@ export class Component<
return value;
}

// @ts-expect-error
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
option(...args): TProperties {
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { resize as resizeEvent, visibility as visibilityEvents } from '@js/common/core/events/short';
import config from '@js/core/config';
import type { DOMComponentOptions } from '@js/core/dom_component';
import type { UserDefinedElement } from '@js/core/element';
import { getPublicElement } from '@js/core/element';
import { cleanDataRecursive } from '@js/core/element_data';
import errors from '@js/core/errors';
Expand Down Expand Up @@ -52,7 +53,7 @@ class DOMComponent<
private _requireRefresh?: boolean;

// eslint-disable-next-line @typescript-eslint/no-explicit-any
private _templateManager?: any;
_templateManager!: any;

// eslint-disable-next-line max-len
// eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/explicit-module-boundary-types
Expand Down Expand Up @@ -493,7 +494,7 @@ class DOMComponent<
return this._$element;
}

element(): Element {
element(): HTMLElement {
const $element = this.$element();

return getPublicElement($element);
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/core/widget/widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ class Widget<
this.$element().toggleClass('dx-state-independent', ignoreParentReadOnly);
}

_setWidgetOption(widgetName: 'string', args: Record<string, unknown>): void {
_setWidgetOption(widgetName: string, args: Record<string, unknown>): void {
if (!this[widgetName]) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,7 @@ class FilterBuilder extends Widget<any> {
return action && action(options);
}

_initMarkup() {
// @ts-expect-error
_initMarkup(): void {
this.$element().addClass(FILTER_BUILDER_CLASS);
// @ts-expect-error
super._initMarkup();
Expand Down Expand Up @@ -391,11 +390,8 @@ class FilterBuilder extends Widget<any> {
_createButtonWithMenu(options) {
const that = this;
const removeMenu = function () {
// @ts-expect-error
that.$element().find(`.${ACTIVE_CLASS}`).removeClass(ACTIVE_CLASS).attr('aria-expanded', 'false');
// @ts-expect-error
that.$element().find('.dx-overlay .dx-treeview').remove();
// @ts-expect-error
that.$element().find('.dx-overlay').remove();
};
const rtlEnabled = this.option('rtlEnabled');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export class ContextMenuView extends modules.View {
},

cssClass: this.getWidgetContainerClass(),
// @ts-expect-error
target: this.component.$element(),
},
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2154,7 +2154,6 @@ class EditingControllerImpl extends modules.ViewController {
setTimeout(() => {
// NOTE: if the editForm is enabled then we need to search for focused element in the document root
// otherwise we need to search for element in the shadow dom
// @ts-expect-error
const elementContainer = this._editForm?.element() || this.component.$element().get(0);
const $focusedElement = $(domAdapter.getActiveElement(elementContainer));
const columnIndex = this._rowsView.getCellIndex($focusedElement, row.rowIndex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,6 @@ export class KeyboardNavigationController extends modules.ViewController {
activeElementSelector
+= ', .dx-datagrid-rowsview .dx-row > td[tabindex]';
}
// @ts-expect-error
element = this.component.$element().find(activeElementSelector).first();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ export class ResizingController extends modules.ViewController {
const widgetStatusText = messageLocalization
// @ts-expect-error Badly typed format method
.format(widgetAriaLabel, totalItemsCount, columnCount);
// @ts-expect-error Badly typed dxElementWrapper
const $ariaLabelElement = this.component.$element().children(`.${GRIDBASE_CONTAINER_CLASS}`);
// @ts-expect-error Treelist Variable
const expandableWidgetAriaLabel = messageLocalization.format(this._expandableWidgetAriaId);
Expand Down Expand Up @@ -361,7 +360,6 @@ export class ResizingController extends modules.ViewController {

this._toggleContentMinHeight(wordWrapEnabled); // T1047239

// @ts-expect-error
if ($element && $element.get(0) && this._maxWidth) {
delete this._maxWidth;
$element[0].style.maxWidth = '';
Expand Down Expand Up @@ -508,7 +506,7 @@ export class ResizingController extends modules.ViewController {
const borderWidth = gridCoreUtils.getComponentBorderWidth(this, $rowsViewElement);

that._maxWidth = totalWidth + scrollbarWidth + borderWidth;
// @ts-expect-error

$element.css('maxWidth', that._maxWidth);
}
}
Expand Down Expand Up @@ -603,7 +601,6 @@ export class ResizingController extends modules.ViewController {
}

private _getGroupElement() {
// @ts-expect-error
return this.component.$element().children().get(0);
}

Expand Down Expand Up @@ -704,15 +701,15 @@ export class ResizingController extends modules.ViewController {
private _resetGroupElementHeight() {
const groupElement = this._getGroupElement();
const scrollable = this._rowsView.getScrollable();

// @ts-expect-error
if (groupElement && groupElement.style.height && (!scrollable || !scrollable.scrollTop())) {
// @ts-expect-error
groupElement.style.height = '';
}
}

private _checkSize(checkSize?) {
const $rootElement = this.component.$element();
// @ts-expect-error
const isWidgetVisible = $rootElement.is(':visible');
const isGridSizeChanged = this._lastWidth !== getWidth($rootElement)
|| this._lastHeight !== getHeight($rootElement)
Expand Down Expand Up @@ -779,6 +776,7 @@ export class ResizingController extends modules.ViewController {
// eslint-disable-next-line radix
const maxHeight = parseInt($rootElement.css('maxHeight'));
const maxHeightHappened = maxHeight && rootElementHeight >= maxHeight;
// @ts-expect-error
const isMaxHeightApplied = groupElement && groupElement.scrollHeight === groupElement.offsetHeight;

that.updateSize($rootElement);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export class Appointment extends DOMComponent {
return messageLocalization.format('dxScheduler-appointmentAriaLabel-group', groupText);
}

_getDateText() {
_getDateText(): string {
const startDateText = this._localizeDate(this._getStartDate());
const endDateText = this._localizeDate(this._getEndDate());

Expand All @@ -203,8 +203,7 @@ export class Appointment extends DOMComponent {
return `${dateText}${partText}`;
}

_renderAriaLabel() {
// @ts-expect-error
_renderAriaLabel(): void {
const $element: dxElementWrapper = this.$element();
const ariaLabel = [
this._getDateText(),
Expand All @@ -220,7 +219,7 @@ export class Appointment extends DOMComponent {
$element.find('.dx-item-content').attr('id', id);
}

_renderAppointmentGeometry() {
_renderAppointmentGeometry(): void {
const geometry: any = this.option('geometry');
const $element: any = this.$element();
move($element, {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,23 @@ export default class SchedulerCalendar extends Widget<dxSchedulerOptions> {
this._overlay.hide();
}

_keyboardHandler(opts) {
_keyboardHandler(opts): void {
this._calendar?._keyboardHandler(opts);
}

_init() {
_init(): void {
// @ts-expect-error
super._init();
this.$element();
}

_render() {
_render(): void {
// @ts-expect-error
super._render();
this._renderOverlay();
}

_renderOverlay() {
// @ts-expect-error
_renderOverlay(): void {
this.$element().addClass(CALENDAR_POPOVER_CLASS);

const isMobileLayout = this._isMobileLayout();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class SchedulerHeader extends Widget<dxSchedulerOptions> {
// @ts-expect-error
super._init();
this._createEventMap();
// @ts-expect-error

this.$element().addClass(COMPONENT_CLASS);

this.currentView = viewsUtils.getCurrentView(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2612,11 +2612,10 @@ class SchedulerWorkSpace extends WidgetObserver {
this._appendHeaderPanelEmptyCellIfNecessary();
this._$headerPanelContainer.append(this._$headerTablesContainer);

this.$element().append(
this._$fixedContainer,
this._$headerPanelContainer,
this._dateTableScrollable.$element(),
);
this.$element()
.append(this._$fixedContainer)
.append(this._$headerPanelContainer)
.append(this._dateTableScrollable.$element());
}

_createWorkSpaceScrollableElements() {
Expand Down
Loading

0 comments on commit ceb5585

Please sign in to comment.