Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prometheus instrumentator for fastapi app #80

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Adding prometheus instrumentator for fastapi app #80

merged 2 commits into from
Dec 26, 2023

Conversation

gitkvark
Copy link
Contributor

Installing the Prometheus FastAPI Instrumentator.
https://github.com/trallnag/prometheus-fastapi-instrumentator
And a bit of cleanup.

@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 0 to add, 0 to change, 0 to destroy.

Terraform Cloud Plan

JoAngel8
JoAngel8 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@JoAngel8 JoAngel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New feature 👍
Versions has been added.

The "Instrumentator" will exposed the metrics by : URL/metrics for Prometheus. Not impacted the application.

@gitkvark gitkvark self-assigned this Dec 26, 2023
@gitkvark gitkvark merged commit d5b52dd into main Dec 26, 2023
1 check passed
@gitkvark gitkvark deleted the fastapi_prometheus branch December 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoAngel8 JoAngel8 JoAngel8 approved these changes

@silopolis silopolis silopolis approved these changes

Assignees

@gitkvark gitkvark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitkvark @silopolis @JoAngel8