Code cleanup

DevTeam · Dec 19, 2024 · 034dc0a · 034dc0a
1 parent 5f0aaa9
commit 034dc0a
Show file tree

Hide file tree

Showing 19 changed files with 44 additions and 49 deletions.
diff --git a/src/Pure.DI.Core/Core/Attributes.cs b/src/Pure.DI.Core/Core/Attributes.cs
@@ -1,5 +1,6 @@
 // ReSharper disable HeapView.DelegateAllocation
 
+// ReSharper disable ClassNeverInstantiated.Global
 namespace Pure.DI.Core;
 
 internal class Attributes(ISemantic semantic)

diff --git a/src/Pure.DI.Core/Core/BindingsValidator.cs b/src/Pure.DI.Core/Core/BindingsValidator.cs
@@ -1,4 +1,5 @@
-#pragma warning disable CS9113 // Parameter is unread.
+// ReSharper disable ClassNeverInstantiated.Global
+#pragma warning disable CS9113 // Parameter is unread.
 namespace Pure.DI.Core;
 
 internal class BindingsValidator(ILogger logger, IRegistry<MdBinding> registry)

diff --git a/src/Pure.DI.Core/Core/Code/Compilations.cs b/src/Pure.DI.Core/Core/Code/Compilations.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core.Code;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core.Code;
 
 public class Compilations : ICompilations
 {

diff --git a/src/Pure.DI.Core/Core/Code/Injections.cs b/src/Pure.DI.Core/Core/Code/Injections.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core.Code;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core.Code;
 
 internal class Injections : IInjections
 {

diff --git a/src/Pure.DI.Core/Core/Code/Locks.cs b/src/Pure.DI.Core/Core/Code/Locks.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core.Code;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core.Code;
 
 internal class Locks(ITypes types) : ILocks
 {

diff --git a/src/Pure.DI.Core/Core/Code/TagClassBuilder.cs b/src/Pure.DI.Core/Core/Code/TagClassBuilder.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core.Code;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core.Code;
 
 internal class TagClassBuilder(
     IInformation information,
@@ -67,8 +68,6 @@ where dependency.Injection.Tag is string
 
                             code.AppendLine("/// </list>");
                         }
-
-
                     }
 
                     code.AppendLine("/// </summary>");

diff --git a/src/Pure.DI.Core/Core/Code/TriviaTools.cs b/src/Pure.DI.Core/Core/Code/TriviaTools.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core.Code;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core.Code;
 
 public class TriviaTools : ITriviaTools
 {

diff --git a/src/Pure.DI.Core/Core/GraphWalker.cs b/src/Pure.DI.Core/Core/GraphWalker.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core;
 
 internal class GraphWalker<TContext, T> : IGraphWalker<TContext, T>
 {

diff --git a/src/Pure.DI.Core/Core/IRegistry.cs b/src/Pure.DI.Core/Core/IRegistry.cs
@@ -1,8 +1,6 @@
 namespace Pure.DI.Core;
 
-internal interface IRegistry<T>
+internal interface IRegistry<in T>
 {
     bool IsRegistered(MdSetup setup, T value);
-
-    IEnumerable<T> GetRegistrations();
 }
diff --git a/src/Pure.DI.Core/Core/InstanceDpProvider.cs b/src/Pure.DI.Core/Core/InstanceDpProvider.cs
@@ -1,3 +1,4 @@
+// ReSharper disable ClassNeverInstantiated.Global
 namespace Pure.DI.Core;
 
 internal class InstanceDpProvider(

diff --git a/src/Pure.DI.Core/Core/LifetimeAnalyzer.cs b/src/Pure.DI.Core/Core/LifetimeAnalyzer.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core;
 
 internal class LifetimeAnalyzer : ILifetimeAnalyzer
 {

diff --git a/src/Pure.DI.Core/Core/Models/DpImplementation.cs b/src/Pure.DI.Core/Core/Models/DpImplementation.cs
@@ -1,5 +1,6 @@
 // ReSharper disable HeapView.ObjectAllocation
 
+// ReSharper disable NotAccessedPositionalProperty.Global
 namespace Pure.DI.Core.Models;
 
 internal record DpImplementation(

diff --git a/src/Pure.DI.Core/Core/Models/LogEntry.cs b/src/Pure.DI.Core/Core/Models/LogEntry.cs
@@ -1,5 +1,6 @@
 // ReSharper disable HeapView.BoxingAllocation
 
+// ReSharper disable NotAccessedPositionalProperty.Global
 namespace Pure.DI.Core.Models;
 
 public readonly record struct LogEntry(

diff --git a/src/Pure.DI.Core/Core/Registry.cs b/src/Pure.DI.Core/Core/Registry.cs
@@ -23,16 +23,7 @@ public bool IsRegistered(MdSetup setup, T value)
         }
     }
 
-    public IEnumerable<T> GetRegistrations()
-    {
-        List<T> result;
-        lock (_registered)
-        {
-            result = _registered.Select(i => i.Value).ToList();
-        }
-
-        return result;
-    }
-
-    private readonly record struct Key(CompositionName CompositionName, T Value);
+    private readonly record struct Key(
+        CompositionName CompositionName,
+        T Value);
 }
diff --git a/src/Pure.DI.Core/Core/RootAccessModifierResolver.cs b/src/Pure.DI.Core/Core/RootAccessModifierResolver.cs
@@ -1,4 +1,5 @@
-namespace Pure.DI.Core;
+// ReSharper disable ClassNeverInstantiated.Global
+namespace Pure.DI.Core;
 
 internal class RootAccessModifierResolver : IRootAccessModifierResolver
 {

diff --git a/src/Pure.DI.Core/Core/Semantic.cs b/src/Pure.DI.Core/Core/Semantic.cs
@@ -106,35 +106,25 @@ when memberAccessExpressionSyntax.IsKind(SyntaxKind.SimpleMemberAccessExpression
                             break;
 
                         case nameof(Tag) when typeof(T) == typeof(object):
-                            switch (valueStr)
+                            return valueStr switch
                             {
-                                case nameof(Tag.Type) when IsSpecialType(semanticModel, node, SpecialType.Tag):
-                                    return (T)(object)Tag.Type;
-
-                                case nameof(Tag.Unique) when IsSpecialType(semanticModel, node, SpecialType.Tag):
-                                    return (T)(object)Tag.Unique;
-
-                                default:
-                                    return (T)smartTags.Register(valueStr);
-                            }
+                                nameof(Tag.Type) when IsSpecialType(semanticModel, node, SpecialType.Tag) => (T)(object)Tag.Type,
+                                nameof(Tag.Unique) when IsSpecialType(semanticModel, node, SpecialType.Tag) => (T)(object)Tag.Unique,
+                                _ => (T)smartTags.Register(valueStr)
+                            };
                     }
                 }
 
                 break;
             }
 
             case IdentifierNameSyntax identifierNameSyntax when typeof(T) == typeof(object):
-                switch (identifierNameSyntax.Identifier.Text)
+                return identifierNameSyntax.Identifier.Text switch
                 {
-                    case nameof(Tag.Type) when IsSpecialType(semanticModel, node, SpecialType.Tag):
-                        return (T)(object)Tag.Type;
-
-                    case nameof(Tag.Unique) when IsSpecialType(semanticModel, node, SpecialType.Tag):
-                        return (T)(object)Tag.Unique;
-
-                    default:
-                        return (T)smartTags.Register(identifierNameSyntax.Identifier.Text);
-                }
+                    nameof(Tag.Type) when IsSpecialType(semanticModel, node, SpecialType.Tag) => (T)(object)Tag.Type,
+                    nameof(Tag.Unique) when IsSpecialType(semanticModel, node, SpecialType.Tag) => (T)(object)Tag.Unique,
+                    _ => (T)smartTags.Register(identifierNameSyntax.Identifier.Text)
+                };
 
             case InvocationExpressionSyntax invocationExpressionSyntax:
             {

diff --git a/src/Pure.DI.Core/Core/SmartTags.cs b/src/Pure.DI.Core/Core/SmartTags.cs
@@ -1,4 +1,5 @@
 // ReSharper disable InvertIf
+// ReSharper disable ClassNeverInstantiated.Global
 namespace Pure.DI.Core;
 
 internal class SmartTags : ISmartTags

diff --git a/src/Pure.DI.Core/Core/SpecialTypeKey.cs b/src/Pure.DI.Core/Core/SpecialTypeKey.cs
@@ -1,3 +1,6 @@
-namespace Pure.DI.Core;
+// ReSharper disable NotAccessedPositionalProperty.Global
+namespace Pure.DI.Core;
 
-internal record SpecialTypeKey(SpecialType SpecialType, Compilation Compilation);
+internal record SpecialTypeKey(
+    SpecialType SpecialType,
+    Compilation Compilation);
diff --git a/src/Pure.DI.Core/Core/TagOnSitesValidator.cs b/src/Pure.DI.Core/Core/TagOnSitesValidator.cs
@@ -1,4 +1,5 @@
-#pragma warning disable CS9113 // Parameter is unread.
+// ReSharper disable ClassNeverInstantiated.Global
+#pragma warning disable CS9113 // Parameter is unread.
 namespace Pure.DI.Core;
 
 internal class TagOnSitesValidator(ILogger logger, IRegistry<MdInjectionSite> registry)