#44 Disposable Instances Handling - accumulator validating

DevTeam · Mar 27, 2024 · ce81d7d · ce81d7d
1 parent cdaea6f
commit ce81d7d
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/src/Pure.DI.Core/Core/MetadataValidator.cs b/src/Pure.DI.Core/Core/MetadataValidator.cs
@@ -5,7 +5,8 @@ namespace Pure.DI.Core;
 
 internal sealed class MetadataValidator(
     ILogger<MetadataValidator> logger,
-    IBaseSymbolsProvider baseSymbolsProvider)
+    IBaseSymbolsProvider baseSymbolsProvider,
+    IMarker marker)
     : IValidator<MdSetup>
 {
     public bool Validate(MdSetup setup)
@@ -54,11 +55,24 @@ public bool Validate(MdSetup setup)
 
             foreach (var root in roots.Skip(1))
             {
-                logger.CompileError($"The composition root \"{root.Name}\" duplicates the previously declared root \"{roots[0].Name}\"", root.Source.GetLocation(), LogId.ErrorInvalidMetadata);
+                logger.CompileError($"The composition root \"{root.Name}\" duplicates the previously declared root \"{roots[0].Name}\".", root.Source.GetLocation(), LogId.ErrorInvalidMetadata);
                 isValid = false;
             }
         }
 
+        foreach (var accumulator in setup.Accumulators)
+        {
+            if (marker.IsMarkerBased(accumulator.AccumulatorType))
+            {
+                logger.CompileError("Accumulator based on marker type is not supported.", accumulator.Source.GetLocation(), LogId.ErrorInvalidMetadata);
+            }
+
+            if (marker.IsMarkerBased(accumulator.Type))
+            {
+                logger.CompileError("The accumulator cannot accumulate instances based on marker type.", accumulator.Source.GetLocation(), LogId.ErrorInvalidMetadata);
+            }
+        }
+
         if (!isValid)
         {
             throw HandledException.Shared;