Remove ophyd_async_connect (#462)

The device connection is now handled by device_instantiation in dodal.
This function also provides the option on whether to wait for
connection, so it is not needed here too.

Additionally it can lead to undefined (currently) behaviour if the
device is initially created with fake_with_ophyd_sim = True but then
later connected again by blueapi with fake_with_ophyd_sim = False.

This also leaves the sim property on BlueskyContext redundant so
that is removed too.

For full customisation and flexibility of lazy connect we need #440.

Fixes #461.

src/blueapi/core/context.py

@@ -6,14 +6,13 @@
 from types import ModuleType, UnionType
 from typing import Any, Generic, TypeVar, Union, get_args, get_origin, get_type_hints
 
-from bluesky.run_engine import RunEngine, call_in_bluesky_event_loop
+from bluesky.run_engine import RunEngine
 from pydantic import create_model
 from pydantic.fields import FieldInfo, ModelField
 
 from blueapi.config import EnvironmentConfig, SourceKind
 from blueapi.utils import (
     BlueapiPlanModelConfig,
-    connect_ophyd_async_devices,
     load_module_all,
 )
 
@@ -45,7 +44,6 @@ class BlueskyContext:
     plans: dict[str, Plan] = field(default_factory=dict)
     devices: dict[str, Device] = field(default_factory=dict)
     plan_functions: dict[str, PlanGenerator] = field(default_factory=dict)
-    sim: bool = field(default=False)
 
     _reference_cache: dict[type, type] = field(default_factory=dict)
 
@@ -78,13 +76,6 @@ def with_config(self, config: EnvironmentConfig) -> None:
             elif source.kind is SourceKind.DODAL:
                 self.with_dodal_module(mod)
 
-        call_in_bluesky_event_loop(
-            connect_ophyd_async_devices(
-                self.devices.values(),
-                self.sim,
-            )
-        )
-
     def with_plan_module(self, module: ModuleType) -> None:
         """
         Register all functions in the module supplied as plans.

src/blueapi/service/handler.py

@@ -154,9 +154,7 @@ def setup_handler(
 
     handler = Handler(
         config,
-        context=BlueskyContext(
-            sim=False,
-        ),
+        context=BlueskyContext(),
     )
     handler.start()
 

src/blueapi/utils/__init__.py

@@ -1,7 +1,6 @@
 from .base_model import BlueapiBaseModel, BlueapiModelConfig, BlueapiPlanModelConfig
 from .invalid_config_error import InvalidConfigError
 from .modules import load_module_all
-from .ophyd_async_connect import connect_ophyd_async_devices
 from .serialization import serialize
 from .thread_exception import handle_all_exceptions
 
@@ -14,5 +13,4 @@
     "BlueapiModelConfig",
     "BlueapiPlanModelConfig",
     "InvalidConfigError",
-    "connect_ophyd_async_devices",
 ]