Mock sleep #228
Closed
Mock sleep #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase this once the transaction worker has been merged... and change the history |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 40 40
Lines 1168 1168
=======================================
Hits 1055 1055
Misses 113 113 ☔ View full report in Codecov by Sentry. |
|
Very out of date, hopefully can be dealt with in follow-ons from #611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow on from a discussion with @DiamondJoseph on #202. We sat down and got asyncio.sleep to be mocked in the RunEngine so that reworker tests don't have to wait for anything.