Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devices connect with a timeout #321

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Make devices connect with a timeout #321

merged 4 commits into from
Oct 26, 2023

Conversation

callumforrester
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #321 (2545fd7) into main (1f9dadf) will decrease coverage by 1.15%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   88.19%   87.04%   -1.15%     
==========================================
  Files          40       41       +1     
  Lines        1516     1544      +28     
==========================================
+ Hits         1337     1344       +7     
- Misses        179      200      +21     
Files Coverage Δ
src/blueapi/core/context.py 97.43% <100.00%> (+2.16%) ⬆️
src/blueapi/utils/__init__.py 100.00% <100.00%> (ø)
src/blueapi/utils/ophyd_async_connect.py 35.13% <35.13%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rosesyrett
Copy link
Contributor

any tests for this will fail: see bluesky/ophyd-async#39

Going to follow this up eventually by moving the stuff in ophyd_async_connect into ophyd_async.

@callumforrester callumforrester merged commit 42cac05 into main Oct 26, 2023
22 of 23 checks passed
@callumforrester callumforrester deleted the connect-timeout branch October 26, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants