-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
366 add cli commands to inspectrestart the environment #409
366 add cli commands to inspectrestart the environment #409
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 90.71% 91.06% +0.34%
==========================================
Files 40 40
Lines 1745 1779 +34
==========================================
+ Hits 1583 1620 +37
+ Misses 162 159 -3 ☔ View full report in Codecov by Sentry. |
ba583c4
to
d790fe1
Compare
not sure what convention do we want to settle on here @callumforrester |
But the handle error must be in the cli. Otherwise you either quit the program or return something |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stan-dot nearly there! Just a couple more things and a rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve once the vscode config diff goes away and a rebase is done
rebase is complex |
will do hectic rebase tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
(once conflicts are resolved)
this if failing due to testing coverage. to mock the polling right, we'd need to mock the devices being restarted. the polling logic is simple and custom, not sure what should happen here |
4fde54c
to
836baec
Compare
the CLI demands the access to RabbitMQ. should we spin one up as part of a docker-compose config with devcontainers? |
@stan-dot it is already spun up, see how the stomp tests are configured |
3fcddf6
to
1c2903e
Compare
cdf1fae
to
94a7b05
Compare
1f7e201
to
d0d9694
Compare
No description provided.