Extend formatting options to listen subcommand #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 92.48% 92.66% +0.17%
==========================================
Files 35 35
Lines 1637 1663 +26
==========================================
+ Hits 1514 1541 +27
+ Misses 123 122 -1 ☔ View full report in Codecov by Sentry. |
tpoliaw
force-pushed
the
listen_format
branch
3 times, most recently
from
8c688a0
to
022d6e3
Compare
callumforrester
approved these changes
Sep 2, 2024
tpoliaw
force-pushed
the
listen_format
branch
from
a1f65b9
to
c49b1b9
Compare
callumforrester
approved these changes
Sep 5, 2024
tpoliaw
force-pushed
the
listen_format
branch
2 times, most recently
from
aa5a0eb
to
6e15a10
Compare
Listen streams a mix of WorkerEvent, ProgressEvent and DataEvent instances for anything that the server is doing. This extends the type handling in the format to each of these types to display the relevant level of information for each. Informational messages are changed to be printed to stderr so that the main stdout output can be piped to an external application (eg jq for json mode).
f'{Foo.A}' uses str.__format__ in 3.10 but enum.__format__ in 3.11+.
Use the name attribute to work with the string directly to ensure the
same behaviour in both environments.
tpoliaw
force-pushed
the
listen_format
branch
from
b1062e2
to
0192ef0
Compare
And cover the missing two lines to get to coverage threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen streams a mix of WorkerEvent, ProgressEvent and DataEvent
instances for anything that the server is doing. This extends the type
handling in the format to each of these types to display the relevant
level of information for each.
Informational messages are changed to be printed to stderr so that the
main stdout output can be piped to an external application (eg jq for
json mode).