Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Dodal with Pydantic2 support, remove deprecated Pydantic usage #625

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

DiamondJoseph
Copy link
Collaborator

closes #622

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (012238d) to head (d5fd0c2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/blueapi/cli/cli.py 0.00% 2 Missing ⚠️
src/blueapi/utils/serialization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   92.52%   92.52%   -0.01%     
==========================================
  Files          35       35              
  Lines        1633     1632       -1     
==========================================
- Hits         1511     1510       -1     
  Misses        122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as my understanding of blueapi goes. Is the failing test relevant?

@DiamondJoseph
Copy link
Collaborator Author

Looks good as far as my understanding of blueapi goes. Is the failing test relevant?

Just that the dev-requirements wasn't updated, which is caught now.

@DiamondJoseph DiamondJoseph merged commit ec13eac into main Sep 6, 2024
23 of 24 checks passed
@DiamondJoseph DiamondJoseph deleted the dodal-update branch September 6, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pydantic 2 depreciations
2 participants