Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sonarcloud workflow #628

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Add sonarcloud workflow #628

merged 9 commits into from
Sep 24, 2024

Conversation

stan-dot
Copy link
Contributor

@stan-dot stan-dot commented Sep 9, 2024

Fixes #595 (fully this time)

@stan-dot stan-dot added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Sep 9, 2024
@stan-dot stan-dot self-assigned this Sep 9, 2024
@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from d138486 to f23fdaa Compare September 9, 2024 10:12
@DiamondJoseph
Copy link
Contributor

Do you know if we have a SONAR_ORG_KEY or who would be able to generate one?

@stan-dot
Copy link
Contributor Author

stan-dot commented Sep 9, 2024

@DiamondJoseph I do not have one, plausibly @callumforrester signed up for the account for the DLS org and the key can be found / generated there

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (8b35390) to head (303f16f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          35       35           
  Lines        1654     1654           
=======================================
  Hits         1532     1532           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callumforrester
Copy link
Contributor

I did not...
You will have to figure out who owns it and approach them

@DiamondJoseph
Copy link
Contributor

I did not... You will have to figure out who owns it and approach them

@callumforrester you are an owner of this org. I presume we'd want to actually make a request in #github-requests on Slack for further input. Especially since the pricing is anywhere from $0-$21,000pa, so wouldn't want to accidentally press the wrong button. :D

@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch 3 times, most recently from a83eda1 to eb82a8b Compare September 11, 2024 14:51
@stan-dot
Copy link
Contributor Author

need to add org key

@stan-dot stan-dot marked this pull request as ready for review September 12, 2024 14:00
@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from eb82a8b to 15d873e Compare September 16, 2024 08:53
@stan-dot
Copy link
Contributor Author

now debugging this

08:59:50.762 ERROR main component does not belong to specified organization

which surprisingly only pops up after analysis has run succesfully for 40 seconds

@stan-dot stan-dot force-pushed the 595-configure-codeql-and-sonarcloud branch from cef1109 to 303f16f Compare September 23, 2024 08:37
@stan-dot stan-dot merged commit cd91f0f into main Sep 24, 2024
27 checks passed
@stan-dot stan-dot deleted the 595-configure-codeql-and-sonarcloud branch September 24, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure CodeQL and sonarcloud
4 participants