-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sonarcloud workflow #628
Conversation
d138486
to
f23fdaa
Compare
Do you know if we have a SONAR_ORG_KEY or who would be able to generate one? |
@DiamondJoseph I do not have one, plausibly @callumforrester signed up for the account for the DLS org and the key can be found / generated there |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 35 35
Lines 1654 1654
=======================================
Hits 1532 1532
Misses 122 122 ☔ View full report in Codecov by Sentry. |
I did not... |
@callumforrester you are an owner of this org. I presume we'd want to actually make a request in #github-requests on Slack for further input. Especially since the pricing is anywhere from $0-$21,000pa, so wouldn't want to accidentally press the wrong button. :D |
a83eda1
to
eb82a8b
Compare
need to add org key |
eb82a8b
to
15d873e
Compare
now debugging this
which surprisingly only pops up after analysis has run succesfully for 40 seconds |
cef1109
to
303f16f
Compare
Fixes #595 (fully this time)